From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt()
Date: Mon, 27 Aug 2012 13:45:51 -0700 [thread overview]
Message-ID: <20120827204550.GA4400@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <003101cd8367$3476e650$9d64b2f0$@samsung.com>
On Sun, Aug 26, 2012 at 05:45:54PM +0900, ????? wrote:
> SND_SOC_DAIFMT_CONT option is now needed because of below commit:
>
> ASoC: Allow DAI formats to be specified in the dai_link
Clearly it's not a direct consequence of this commit, that just
introduces a new optional facility which...
> /* Set the cpu DAI configuration */
> ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_DSP_B
> + | SND_SOC_DAIFMT_CONT
> | SND_SOC_DAIFMT_IB_NF
> | SND_SOC_DAIFMT_CBS_CFS);
...isn't being used by the driver.
Looking at the above it looks like the PCM driver is doing something
very odd - _CONT doesn't make a whole lot of sense on the slave side,
it's related to the clock generation so should have no effect at all on
the slave side. The driver code looks reasonably sensible though.
What specifically is going wrong here?
next prev parent reply other threads:[~2012-08-27 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 8:45 [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt() 박상수
2012-08-27 20:45 ` Mark Brown [this message]
2012-08-29 11:06 ` Sangsu Park
2012-08-30 17:43 ` Mark Brown
2012-09-03 2:10 ` Sangsu Park
2012-09-06 0:21 ` Mark Brown
2012-09-06 8:57 ` Sangsu Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120827204550.GA4400@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).