From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx21ads : avoid overlapping static i/o mappings
Date: Tue, 28 Aug 2012 08:47:10 +0200 [thread overview]
Message-ID: <20120828064710.GP26594@pengutronix.de> (raw)
In-Reply-To: <1346016938-28175-1-git-send-email-jaccon.bastiaansen@gmail.com>
On Sun, Aug 26, 2012 at 11:35:38PM +0200, Jaccon Bastiaansen wrote:
> The static I/O mappings for the cs89x0 ethernet controller and the
> secondary AHB port 1 (SAHB1) overlapped, causing a kernel crash
> at startup. This is fixed by mapping the cs89x0 to 0xf6000000 (which
> is free to use according to arch/arm/plat-mxc/include/mach/hardware.h).
>
> Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
> ---
> arch/arm/mach-imx/mach-mx21ads.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mach-mx21ads.c b/arch/arm/mach-imx/mach-mx21ads.c
> index ed22e3f..712c90e 100644
> --- a/arch/arm/mach-imx/mach-mx21ads.c
> +++ b/arch/arm/mach-imx/mach-mx21ads.c
> @@ -31,7 +31,7 @@
> /*
> * Memory-mapped I/O on MX21ADS base board
> */
> -#define MX21ADS_MMIO_BASE_ADDR 0xf5000000
> +#define MX21ADS_MMIO_BASE_ADDR 0xf6000000
I would prefer to ioremap the region instead. This makes sure this
problem is solved once and for all.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2012-08-28 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 21:35 [PATCH] imx21ads : avoid overlapping static i/o mappings Jaccon Bastiaansen
2012-08-28 6:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828064710.GP26594@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).