linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: fix imx51 babbage SD2 CD/WP
Date: Tue, 28 Aug 2012 10:06:45 +0200	[thread overview]
Message-ID: <20120828080645.GA26594@pengutronix.de> (raw)
In-Reply-To: <1345779227-3700-1-git-send-email-shawn.guo@linaro.org>

On Fri, Aug 24, 2012 at 11:33:47AM +0800, Shawn Guo wrote:
> Pads GPIO1_6 and GPIO1_5 are used as SD2 CD/WP on imx51 babbage board.
> Before commit 5d23b39 (ARM: i.MX51 iomux: add missed definitions for
> SION-bit and mode for some pads) gets in, we use the pad settings
> configured by bootloader with NO_PAD_CTRL and SD2 CD/WP just works.
> The commit changes the pad settings and causes SD2 CD/WP stop working.
> 
> Set up pads GPIO1_6 and GPIO1_5 in the configuation that bootloader
> uses on imx51 babbage board to fix the SD2 CD/WP regression.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
>  arch/arm/mach-imx/mach-mx51_babbage.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx51_babbage.c b/arch/arm/mach-imx/mach-mx51_babbage.c
> index 7b31cbd..83f49c4 100644
> --- a/arch/arm/mach-imx/mach-mx51_babbage.c
> +++ b/arch/arm/mach-imx/mach-mx51_babbage.c
> @@ -154,8 +154,8 @@ static iomux_v3_cfg_t mx51babbage_pads[] = {
>  	MX51_PAD_SD2_DATA2__SD2_DATA2,
>  	MX51_PAD_SD2_DATA3__SD2_DATA3,
>  	/* CD/WP gpio */
> -	MX51_PAD_GPIO1_6__GPIO1_6,
> -	MX51_PAD_GPIO1_5__GPIO1_5,
> +	NEW_PAD_CTRL(MX51_PAD_GPIO1_6__GPIO1_6, PAD_CTL_HYS),
> +	NEW_PAD_CTRL(MX51_PAD_GPIO1_5__GPIO1_5, PAD_CTL_HYS),
>  
>  	/* eCSPI1 */
>  	MX51_PAD_CSPI1_MISO__ECSPI1_MISO,
> -- 
> 1.7.5.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2012-08-28  8:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  3:33 [PATCH] ARM: imx: fix imx51 babbage SD2 CD/WP Shawn Guo
2012-08-28  8:06 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828080645.GA26594@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).