From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data
Date: Wed, 29 Aug 2012 09:31:31 +0100 [thread overview]
Message-ID: <20120829083129.GB3439@gmail.com> (raw)
In-Reply-To: <20120828172133.GH4534@opensource.wolfsonmicro.com>
On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote:
> On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote:
>
> > > > arch/arm/boot/dts/db8500.dtsi
>
> > > I'm not actually seeing anything terribly problematic here, though the
> > > regulator-name properties should really be removed as they're fairly
> > > useless and seem to be missing the point of having the property.
>
> > Just looking at this now.
>
> > The regulator-name property is used to populate constrains->name. Are
> > you sure you still want them all removed?
>
> Yes, of course. There's no way that a generic .dtsi used for any
> possible board could come up with a sensible value.
So how should constrains->name be populated then? Would you prefer
regulator-names moved to the .dts file(s), or something else?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-08-29 8:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 6:46 [PATCH 0/4] Add AM33XX regulators device tree data AnilKumar Ch
2012-07-20 6:46 ` [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 " AnilKumar Ch
2012-07-20 9:59 ` Mark Brown
2012-07-20 11:27 ` AnilKumar, Chimata
2012-07-20 11:38 ` Mark Brown
2012-07-23 7:06 ` AnilKumar, Chimata
2012-07-23 13:23 ` AnilKumar, Chimata
2012-07-23 13:34 ` Mark Brown
2012-07-23 13:48 ` Lee Jones
2012-08-28 11:26 ` Lee Jones
2012-08-28 17:21 ` Mark Brown
2012-08-29 8:31 ` Lee Jones [this message]
2012-08-30 16:59 ` Mark Brown
2012-07-20 6:46 ` [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 " AnilKumar Ch
2012-07-20 10:01 ` Mark Brown
2012-07-20 6:46 ` [PATCH 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts AnilKumar Ch
2012-07-20 6:46 ` [PATCH 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts AnilKumar Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120829083129.GB3439@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).