linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage
Date: Thu, 30 Aug 2012 01:08:49 +0100	[thread overview]
Message-ID: <20120830000849.GD25765@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1346230576-20004-3-git-send-email-rnayak@ti.com>

On Wed, Aug 29, 2012 at 02:26:15PM +0530, Rajendra Nayak wrote:
> Moving to Common clk framework for OMAP would mean we no longer use
> internal lookup mechanism like omap_clk_get_by_name().
> get rid of all its usage mostly from hwmod and omap_device
> code.
> 
> Also use IS_ERR_OR_NULL() for error checking.

This is wrong.  IS_ERR() is the only check you should ever use with clk_get().

  reply	other threads:[~2012-08-30  0:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29  8:56 [PATCH v4 0/3] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-08-29  8:56 ` [PATCH v4 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-08-30  0:03   ` Turquette, Mike
2012-08-29  8:56 ` [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-08-30  0:08   ` Russell King - ARM Linux [this message]
2012-08-30  8:37     ` Rajendra Nayak
2012-08-30  0:15   ` Turquette, Mike
2012-08-30  8:39     ` Rajendra Nayak
2012-08-30 11:57       ` Benoit Cousson
2012-08-30 16:42         ` Tomi Valkeinen
2012-08-31  6:23           ` Archit Taneja
2012-08-31  7:15             ` Tomi Valkeinen
2012-08-31  8:20               ` Archit Taneja
2012-08-31  8:27                 ` Tomi Valkeinen
2012-08-31  8:28                   ` Archit Taneja
2012-10-05  9:46                     ` OMAP4 clock/pm fixes [was: " Archit Taneja
2012-10-05 12:20                       ` Benoit Cousson
2012-10-05 12:29                         ` Archit Taneja
2012-10-05 12:37                           ` Rajendra Nayak
2012-10-05 13:20                             ` Archit Taneja
2012-10-05 13:31                               ` Rajendra Nayak
2012-10-05 13:46                                 ` Archit Taneja
2012-10-05 13:51                               ` Benoit Cousson
2012-09-22 18:55   ` Paul Walmsley
2012-09-24  5:09     ` Rajendra Nayak
2012-08-29  8:56 ` [PATCH v4 3/3] ARM: OMAP2+: clock: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-08-30 20:56 ` [PATCH v4 0/3] Prepare for OMAP2+ movement to Common Clk Paul Walmsley
2012-08-31  5:03   ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120830000849.GD25765@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).