From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Fri, 31 Aug 2012 10:02:48 +0800 Subject: [PATCH v4 2/7] ARM: imx6q: add iomuxc gpr support into syscon In-Reply-To: <1346237818-9498-3-git-send-email-b29396@freescale.com> References: <1346237818-9498-1-git-send-email-b29396@freescale.com> <1346237818-9498-3-git-send-email-b29396@freescale.com> Message-ID: <20120831020247.GC7726@r65073-Latitude-D630> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 29, 2012 at 06:56:53PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Include headfile for easy using. > > Acked-by: Stephen Warren > Signed-off-by: Dong Aisheng > --- > arch/arm/boot/dts/imx6q.dtsi | 5 + > include/linux/fsl/imx6q-iomuxc-gpr.h | 319 ++++++++++++++++++++++++++++++++++ I assume that all the users of this header file are imx6q syscon clients. In that case, this header belongs to mfd/syscon subsystem. I have been told by people that it was a mistake to create include/linux/fsl. Each header in include/linux should go to respective subsystem sub-directory. For this particular case, it should be include/linux/mfd or include/linux/mfd/syscon even better, IMO. > +#define IMX6Q_GPR13_SATA_PHY_1_MED (0x1 << 0) > +#define IMX6Q_GPR13_SATA_PHY_1_SLOW (0x2 << 0) > + > +#endif /* !__LINUX_IMX6Q_IOMUXC_GPR_H */ Nit: why do we have a "!" there? -- Regards, Shawn