From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 31 Aug 2012 08:52:26 -0700 Subject: Without MACH_ option Early printk (DEBUG_LL) In-Reply-To: <5040D03B.2050304@ti.com> References: <5040D03B.2050304@ti.com> Message-ID: <20120831155226.GL1303@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Vaibhav Hiremath [120831 07:55]: > Hi Russell & Tony, > > AM335X EVM (based on AM33XX device) only supports DT boot mode and > doesn't have CONFIG_MACH_AM335XEVM option defined. Some time back during > baseport submission we had aligned that, we won't create separate EVM > options, killing the board file all-together. > > Having said that, the early printk option (DEBUG_LL) is broken, the > auto-generated file "./include/generated/mach-types.h" still refers to > CONFIG_MACH_AM335XEVM option, The way we're heading is that the DEBUG_LL options will only work for one hardcoded machine where you need to select the uart type and address in Kconfig. Or just patch it in. > #ifdef CONFIG_MACH_AM335XEVM > # ifdef machine_arch_type > # undef machine_arch_type > # define machine_arch_type __machine_arch_type > # else > # define machine_arch_type MACH_TYPE_AM335XEVM > # endif > # define machine_is_am335xevm() (machine_arch_type == MACH_TYPE_AM335XEVM) > #else > # define machine_is_am335xevm() (0) > #endif > > > So I am thinking of changing the config_xxx option to SOC_AM33XX or > ARCH_OMAP2PLUS, something like below, > > am335xevm SOC_AM33XX AM335XEVM 3589 > > OR > > am335xevm ARCH_OMAP2PLUS AM335XEVM 3589 > > > Can you comment on this? Based on that I will submit the patch. I think that would at minimum break things for autogenerated mach-types.h where if only some other non-am335xevm machine is selected (like omap-generic) things don't get optimized out any longer as they currently do. Regards, Tony