From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 2/4] can: c_can: Add d_can raminit support
Date: Wed, 5 Sep 2012 16:23:53 -0700 [thread overview]
Message-ID: <20120905232353.GK1303@atomide.com> (raw)
In-Reply-To: <1346843564-25343-3-git-send-email-anilkumar@ti.com>
* AnilKumar Ch <anilkumar@ti.com> [120905 04:14]:
> Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM,
> which holds all the message objects during transmission or
> receiving of data. This initialization/de-initialization should
> be done in synchronous with D_CAN clock.
Sounds like you should just implement runtime PM calls in the driver
and let the lower level code take care of this for you along with the
clocks etc.
> @@ -1071,6 +1077,8 @@ static int c_can_open(struct net_device *dev)
> struct c_can_priv *priv = netdev_priv(dev);
>
> c_can_pm_runtime_get_sync(priv);
> + /* Initialize DCAN RAM */
> + c_can_reset_ram(priv, true);
>
> /* open the can device */
> err = open_candev(dev);
> @@ -1099,6 +1107,8 @@ static int c_can_open(struct net_device *dev)
> exit_irq_fail:
> close_candev(dev);
> exit_open_fail:
> + /* De-Initialize DCAN RAM */
> + c_can_reset_ram(priv, false);
> c_can_pm_runtime_put_sync(priv);
> return err;
> }
Oh your already have pm_runtime here, OK so yeah let's let the omap/am33xx
hwmod code do this for you. No changes to this driver needed then?
Tony
next prev parent reply other threads:[~2012-09-05 23:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:12 [PATCH v2 0/4] can: c_can: Add suspend/resume and pinctrl support AnilKumar Ch
2012-09-05 11:12 ` [PATCH RESEND 1/4] can: c_can: Adopt " AnilKumar Ch
2012-09-05 23:19 ` Tony Lindgren
2012-09-05 11:12 ` [PATCH RESEND 2/4] can: c_can: Add d_can raminit support AnilKumar Ch
2012-09-05 23:23 ` Tony Lindgren [this message]
2012-09-05 11:12 ` [PATCH RESEND 3/4] ARM: AM33XX: board-generic: Add of_dev_auxdata to pass d_can raminit AnilKumar Ch
2012-09-05 23:18 ` Tony Lindgren
2012-09-06 3:56 ` Vaibhav Hiremath
2012-09-06 5:03 ` Bedia, Vaibhav
2012-09-06 5:07 ` Hiremath, Vaibhav
2012-09-05 11:12 ` [PATCH v2 4/4] can: c_can: Add d_can suspend resume support AnilKumar Ch
2012-09-07 8:26 ` AnilKumar, Chimata
2012-09-05 11:54 ` [PATCH v2 0/4] can: c_can: Add suspend/resume and pinctrl support Marc Kleine-Budde
2012-09-05 13:55 ` Marc Kleine-Budde
2012-09-05 23:26 ` Tony Lindgren
2012-09-06 6:09 ` AnilKumar, Chimata
2012-09-06 8:27 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905232353.GK1303@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).