From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] leds: leds-gpio: adopt pinctrl support
Date: Wed, 5 Sep 2012 16:34:18 -0700 [thread overview]
Message-ID: <20120905233416.GP1303@atomide.com> (raw)
In-Reply-To: <201209050513.08588.marex@denx.de>
* Marek Vasut <marex@denx.de> [120904 20:13]:
> Dear Bryan Wu,
>
> > On Sat, Sep 1, 2012 at 4:16 PM, AnilKumar Ch <anilkumar@ti.com> wrote:
> > > Adopt pinctrl support to leds-gpio driver based on leds-gpio
> > > device pointer, pinctrl driver configure SoC pins to GPIO
> > > mode according to definitions provided in .dts file.
> >
> > Thanks for this, actually Marek Vasut submitted a similar patch
> > before. I'm pretty fine with this patch.
>
> Thanks for submitting this actually ... I didn't have time to properly
> investigate this.
>
> > But without proper DT setting, it will also give us warning I think.
> > or we can provide some dummy functions as a temp solution as Shawn
> > pointed out before.
>
> But this driver is also used on hardware that's not yet coverted to DT, so I'd
> say dev_warn() if CONFIG_OF is enabled and otherwise simply go on ? Actually,
> can we not skip whole this pinctrl thing if CONFIG_OF is disabled? Actually (2),
> what's the relationship between OF and pinctrl?
The warning should be pinctrl related as the pinctrl drivers may not be
device tree based drivers.
Regards,
Tony
next prev parent reply other threads:[~2012-09-05 23:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 8:16 [PATCH v2] leds: leds-gpio: adopt pinctrl support AnilKumar Ch
2012-09-05 3:06 ` Bryan Wu
2012-09-05 3:13 ` Marek Vasut
2012-09-05 23:34 ` Tony Lindgren [this message]
2012-09-06 2:05 ` Marek Vasut
2012-09-06 17:45 ` Tony Lindgren
2012-09-07 0:09 ` Marek Vasut
2012-09-07 7:59 ` AnilKumar, Chimata
2012-09-07 8:22 ` Marek Vasut
2012-09-07 16:00 ` Bryan Wu
2012-09-07 21:39 ` Linus Walleij
2012-09-07 21:46 ` Tony Lindgren
2012-09-07 8:48 ` Domenico Andreoli
2012-09-07 9:10 ` AnilKumar, Chimata
2012-09-07 11:02 ` Domenico Andreoli
2012-09-07 14:30 ` AnilKumar, Chimata
2012-09-07 16:00 ` Domenico Andreoli
2012-09-07 16:35 ` Tony Lindgren
2012-09-07 21:59 ` Linus Walleij
2012-09-07 21:57 ` Linus Walleij
2012-09-08 23:44 ` Domenico Andreoli
2012-09-10 15:23 ` Linus Walleij
2012-09-10 17:41 ` Stephen Warren
2012-09-10 19:34 ` Linus Walleij
2012-09-10 19:44 ` Stephen Warren
2012-09-07 21:36 ` Linus Walleij
2012-09-10 19:40 ` Linus Walleij
2012-10-01 7:03 ` AnilKumar, Chimata
2012-10-01 8:24 ` Linus Walleij
2012-10-01 15:44 ` Tony Lindgren
2012-10-01 19:59 ` Linus Walleij
2012-10-03 10:52 ` AnilKumar, Chimata
2012-10-03 12:36 ` Linus Walleij
2012-10-30 14:12 ` AnilKumar, Chimata
2012-11-04 17:37 ` Linus Walleij
2012-11-05 6:44 ` AnilKumar, Chimata
2012-11-05 16:27 ` Tony Lindgren
2012-10-03 15:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905233416.GP1303@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).