From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] pwm i.MX: fix clock lookup
Date: Thu, 6 Sep 2012 09:15:14 +0200 [thread overview]
Message-ID: <20120906071514.GM26594@pengutronix.de> (raw)
In-Reply-To: <1698432111.3713458.1346881731396.JavaMail.root@advansee.com>
On Wed, Sep 05, 2012 at 11:48:51PM +0200, Beno?t Th?baudeau wrote:
> >
> > - c = clk_get_rate(imx->clk);
> > + c = clk_get_rate(imx->clk_per);
> > c = c * period_ns;
> > do_div(c, 1000000000);
> > period_cycles = c;
> > @@ -160,8 +161,15 @@ static int imx_pwm_config(struct pwm_chip *chip,
> > struct pwm_device *pwm, int duty_ns, int period_ns)
> > {
> > struct imx_chip *imx = to_imx_chip(chip);
> > + int ret;
> >
> > - return imx->config(chip, pwm, duty_ns, period_ns);
> > + clk_prepare_enable(imx->clk_ipg);
>
> Why don't you test the return value like in imx_pwm_enable()?
Will do next time.
Sascha
>
> I have reviewed the whole series. Apart from the comments I made, it looks good
> to me.
Thanks. I can take this as a reviewed-by, right?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-09-06 7:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 13:35 [PATCH v2] pwm i.MX: add devicetree support Sascha Hauer
2012-09-05 13:35 ` [PATCH 1/8] pwm i.MX: factor out SoC specific functions Sascha Hauer
2012-09-05 13:35 ` [PATCH 2/8] pwm i.MX: remove unnecessary if in pwm_[en|dis]able Sascha Hauer
2012-09-05 13:35 ` [PATCH 3/8] pwm i.MX: add functions to enable/disable pwm Sascha Hauer
2012-09-05 13:35 ` [PATCH 4/8] pwm i.MX: Use module_platform_driver Sascha Hauer
2012-09-05 13:35 ` [PATCH 5/8] pwm i.MX: add devicetree support Sascha Hauer
2012-09-05 21:42 ` Benoît Thébaudeau
2012-09-06 6:58 ` Sascha Hauer
2012-09-05 13:35 ` [PATCH 6/8] pwm i.MX: use per clock unconditionally Sascha Hauer
2012-09-05 13:35 ` [PATCH 7/8] pwm i.MX: fix clock lookup Sascha Hauer
2012-09-05 21:48 ` Benoît Thébaudeau
2012-09-06 7:15 ` Sascha Hauer [this message]
2012-09-05 13:35 ` [PATCH 8/8] ARM i.MX53: Add pwm support Sascha Hauer
2012-09-06 8:19 ` [PATCH v2] pwm i.MX: add devicetree support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906071514.GM26594@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).