From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Thu, 6 Sep 2012 09:19:33 -0700 Subject: [PATCH v3 08/14] Input: twl4030-vibra: Support for DT booted kernel In-Reply-To: <1346933541-21547-9-git-send-email-peter.ujfalusi@ti.com> References: <1346933541-21547-1-git-send-email-peter.ujfalusi@ti.com> <1346933541-21547-9-git-send-email-peter.ujfalusi@ti.com> Message-ID: <20120906161933.GA18562@core.coreip.homeip.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Peter, On Thu, Sep 06, 2012 at 03:12:15PM +0300, Peter Ujfalusi wrote: > Add support when the kernel has been booted with DT blob. In this case the > pdata is NULL, we need to reach up to the core node and check if the codec > part has been enabled to determine if we need to coexist with the codec or > not. > > Signed-off-by: Peter Ujfalusi > --- > drivers/input/misc/twl4030-vibra.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c > index fc0ed9b..15620f8 100644 > --- a/drivers/input/misc/twl4030-vibra.c > +++ b/drivers/input/misc/twl4030-vibra.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -194,13 +195,28 @@ static int twl4030_vibra_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(twl4030_vibra_pm_ops, > twl4030_vibra_suspend, twl4030_vibra_resume); > > +static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata, > + struct device_node *node) > +{ > + if (pdata && pdata->coexist) > + return true; > + > +#ifdef CONFIG_OF > + if (of_find_node_by_name(node, "codec")) > + return true; > +#endif In patch 6 you added a stub for of_find_node_by_name(), so do you really need this #ifdef? Otherwise it looks good. Acked-by: Dmitry Torokhov Thanks. -- Dmitry