* [PATCH v7 1/3] arm/dts: AM33XX: Add basic pinctrl device tree data
2012-09-06 9:38 [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar Ch
@ 2012-09-06 9:38 ` AnilKumar Ch
2012-09-07 16:58 ` Tony Lindgren
2012-09-06 9:38 ` [PATCH v7 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone AnilKumar Ch
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: AnilKumar Ch @ 2012-09-06 9:38 UTC (permalink / raw)
To: linux-arm-kernel
Adds basic pinctrl device tree data for AM33XX family of devices.
This patch is based on the pinctrl-single driver.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index be43511..58cffb7 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -40,6 +40,15 @@
};
};
+ am33xx_pinmux: pinmux at 44e10800 {
+ compatible = "pinctrl-single";
+ reg = <0x44e10800 0x0238>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-single,register-width = <32>;
+ pinctrl-single,function-mask = <0x7f>;
+ };
+
/*
* XXX: Use a flat representation of the AM33XX interconnect.
* The real AM33XX interconnect network is quite complex.Since
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v7 1/3] arm/dts: AM33XX: Add basic pinctrl device tree data
2012-09-06 9:38 ` [PATCH v7 1/3] arm/dts: AM33XX: Add basic pinctrl device tree data AnilKumar Ch
@ 2012-09-07 16:58 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2012-09-07 16:58 UTC (permalink / raw)
To: linux-arm-kernel
* AnilKumar Ch <anilkumar@ti.com> [120906 02:39]:
> Adds basic pinctrl device tree data for AM33XX family of devices.
> This patch is based on the pinctrl-single driver.
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Assuming Benoit will queue this series:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index be43511..58cffb7 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -40,6 +40,15 @@
> };
> };
>
> + am33xx_pinmux: pinmux at 44e10800 {
> + compatible = "pinctrl-single";
> + reg = <0x44e10800 0x0238>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-single,register-width = <32>;
> + pinctrl-single,function-mask = <0x7f>;
> + };
> +
> /*
> * XXX: Use a flat representation of the AM33XX interconnect.
> * The real AM33XX interconnect network is quite complex.Since
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v7 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone
2012-09-06 9:38 [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar Ch
2012-09-06 9:38 ` [PATCH v7 1/3] arm/dts: AM33XX: Add basic pinctrl device tree data AnilKumar Ch
@ 2012-09-06 9:38 ` AnilKumar Ch
2012-09-07 8:45 ` Koen Kooi
2012-09-06 9:38 ` [PATCH v7 3/3] arm/dts: AM33XX: Add D_CAN device tree data AnilKumar Ch
2012-09-07 5:30 ` [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar, Chimata
3 siblings, 1 reply; 10+ messages in thread
From: AnilKumar Ch @ 2012-09-06 9:38 UTC (permalink / raw)
To: linux-arm-kernel
Adds GPIO pinctrl nodes to am3358_pinmux master node to control
user leds (USR0, USR1, USR2 and USR3) present on BeagleBone.
[koen at dominion.thruhere.net: led0, led1 suggested by koen]
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
arch/arm/boot/dts/am335x-bone.dts | 43 +++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index c634f87..b0a7409 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -18,11 +18,54 @@
reg = <0x80000000 0x10000000>; /* 256 MB */
};
+ am33xx_pinmux: pinmux at 44e10800 {
+ userled_pins: pinmux_userled_pins {
+ pinctrl-single,pins = <
+ 0x54 0x7 /* gpmc_a5.gpio1_21, OUTPUT | MODE7 */
+ 0x58 0x17 /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */
+ 0x5c 0x7 /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */
+ 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */
+ >;
+ };
+ };
+
ocp {
uart1: serial at 44e09000 {
status = "okay";
};
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&userled_pins>;
+
+ heartbeat {
+ label = "beaglebone:green:usr0";
+ gpios = <&gpio2 21 0>;
+ linux,default-trigger = "heartbeat";
+ default-state = "off";
+ };
+
+ mmc {
+ label = "beaglebone:green:usr1";
+ gpios = <&gpio2 22 0>;
+ linux,default-trigger = "mmc0";
+ default-state = "off";
+ };
+
+ led2 {
+ label = "beaglebone:green:usr2";
+ gpios = <&gpio2 23 0>;
+ default-state = "off";
+ };
+
+ led3 {
+ label = "beaglebone:green:usr3";
+ gpios = <&gpio2 24 0>;
+ default-state = "off";
+ };
+ };
+
i2c1: i2c at 44e0b000 {
status = "okay";
clock-frequency = <400000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v7 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone
2012-09-06 9:38 ` [PATCH v7 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone AnilKumar Ch
@ 2012-09-07 8:45 ` Koen Kooi
2012-09-07 17:00 ` Tony Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Koen Kooi @ 2012-09-07 8:45 UTC (permalink / raw)
To: linux-arm-kernel
Op 6 sep. 2012, om 11:38 heeft AnilKumar Ch <anilkumar@ti.com> het volgende geschreven:
> Adds GPIO pinctrl nodes to am3358_pinmux master node to control
> user leds (USR0, USR1, USR2 and USR3) present on BeagleBone.
>
> [koen at dominion.thruhere.net: led0, led1 suggested by koen]
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Acked-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> arch/arm/boot/dts/am335x-bone.dts | 43 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
> index c634f87..b0a7409 100644
> --- a/arch/arm/boot/dts/am335x-bone.dts
> +++ b/arch/arm/boot/dts/am335x-bone.dts
> @@ -18,11 +18,54 @@
> reg = <0x80000000 0x10000000>; /* 256 MB */
> };
>
> + am33xx_pinmux: pinmux at 44e10800 {
> + userled_pins: pinmux_userled_pins {
> + pinctrl-single,pins = <
> + 0x54 0x7 /* gpmc_a5.gpio1_21, OUTPUT | MODE7 */
> + 0x58 0x17 /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */
> + 0x5c 0x7 /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */
> + 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */
> + >;
> + };
> + };
> +
> ocp {
> uart1: serial at 44e09000 {
> status = "okay";
> };
>
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&userled_pins>;
> +
> + heartbeat {
> + label = "beaglebone:green:usr0";
> + gpios = <&gpio2 21 0>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> +
> + mmc {
> + label = "beaglebone:green:usr1";
> + gpios = <&gpio2 22 0>;
> + linux,default-trigger = "mmc0";
> + default-state = "off";
> + };
> +
> + led2 {
> + label = "beaglebone:green:usr2";
> + gpios = <&gpio2 23 0>;
> + default-state = "off";
> + };
> +
> + led3 {
> + label = "beaglebone:green:usr3";
> + gpios = <&gpio2 24 0>;
> + default-state = "off";
> + };
> + };
> +
> i2c1: i2c at 44e0b000 {
> status = "okay";
> clock-frequency = <400000>;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v7 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone
2012-09-07 8:45 ` Koen Kooi
@ 2012-09-07 17:00 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2012-09-07 17:00 UTC (permalink / raw)
To: linux-arm-kernel
* Koen Kooi <koen@dominion.thruhere.net> [120907 01:46]:
>
> Op 6 sep. 2012, om 11:38 heeft AnilKumar Ch <anilkumar@ti.com> het volgende geschreven:
>
> > Adds GPIO pinctrl nodes to am3358_pinmux master node to control
> > user leds (USR0, USR1, USR2 and USR3) present on BeagleBone.
> >
> > [koen at dominion.thruhere.net: led0, led1 suggested by koen]
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>
> Acked-by: Koen Kooi <koen@dominion.thruhere.net>
This one still has the discussion going on about if GPIO pins
should be muxed by the GPIO controller in the "GPIO only" case
for gpio leds driver. But other than that:
Acked-by: Tony Lindgren <tony@atomide.com>
>
> > ---
> > arch/arm/boot/dts/am335x-bone.dts | 43 +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
> > index c634f87..b0a7409 100644
> > --- a/arch/arm/boot/dts/am335x-bone.dts
> > +++ b/arch/arm/boot/dts/am335x-bone.dts
> > @@ -18,11 +18,54 @@
> > reg = <0x80000000 0x10000000>; /* 256 MB */
> > };
> >
> > + am33xx_pinmux: pinmux at 44e10800 {
> > + userled_pins: pinmux_userled_pins {
> > + pinctrl-single,pins = <
> > + 0x54 0x7 /* gpmc_a5.gpio1_21, OUTPUT | MODE7 */
> > + 0x58 0x17 /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */
> > + 0x5c 0x7 /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */
> > + 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */
> > + >;
> > + };
> > + };
> > +
> > ocp {
> > uart1: serial at 44e09000 {
> > status = "okay";
> > };
> >
> > + leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&userled_pins>;
> > +
> > + heartbeat {
> > + label = "beaglebone:green:usr0";
> > + gpios = <&gpio2 21 0>;
> > + linux,default-trigger = "heartbeat";
> > + default-state = "off";
> > + };
> > +
> > + mmc {
> > + label = "beaglebone:green:usr1";
> > + gpios = <&gpio2 22 0>;
> > + linux,default-trigger = "mmc0";
> > + default-state = "off";
> > + };
> > +
> > + led2 {
> > + label = "beaglebone:green:usr2";
> > + gpios = <&gpio2 23 0>;
> > + default-state = "off";
> > + };
> > +
> > + led3 {
> > + label = "beaglebone:green:usr3";
> > + gpios = <&gpio2 24 0>;
> > + default-state = "off";
> > + };
> > + };
> > +
> > i2c1: i2c at 44e0b000 {
> > status = "okay";
> > clock-frequency = <400000>;
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v7 3/3] arm/dts: AM33XX: Add D_CAN device tree data
2012-09-06 9:38 [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar Ch
2012-09-06 9:38 ` [PATCH v7 1/3] arm/dts: AM33XX: Add basic pinctrl device tree data AnilKumar Ch
2012-09-06 9:38 ` [PATCH v7 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone AnilKumar Ch
@ 2012-09-06 9:38 ` AnilKumar Ch
2012-09-07 5:30 ` [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar, Chimata
3 siblings, 0 replies; 10+ messages in thread
From: AnilKumar Ch @ 2012-09-06 9:38 UTC (permalink / raw)
To: linux-arm-kernel
Add Bosch D_CAN controller device tree data to AM33XX dtsi
file by adding d_can device nodes with all the necessary
parameters.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
arch/arm/boot/dts/am33xx.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 58cffb7..600c3053 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -177,5 +177,23 @@
compatible = "ti,omap3-wdt";
ti,hwmods = "wd_timer2";
};
+
+ dcan0: d_can at 481cc000 {
+ compatible = "bosch,d_can";
+ ti,hwmods = "d_can0";
+ reg = <0x481cc000 0x2000>;
+ interrupts = <52>;
+ interrupt-parent = <&intc>;
+ status = "disabled";
+ };
+
+ dcan1: d_can at 481d0000 {
+ compatible = "bosch,d_can";
+ ti,hwmods = "d_can1";
+ reg = <0x481d0000 0x2000>;
+ interrupts = <55>;
+ interrupt-parent = <&intc>;
+ status = "disabled";
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices
2012-09-06 9:38 [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar Ch
` (2 preceding siblings ...)
2012-09-06 9:38 ` [PATCH v7 3/3] arm/dts: AM33XX: Add D_CAN device tree data AnilKumar Ch
@ 2012-09-07 5:30 ` AnilKumar, Chimata
2012-09-07 8:37 ` Benoit Cousson
3 siblings, 1 reply; 10+ messages in thread
From: AnilKumar, Chimata @ 2012-09-07 5:30 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 06, 2012 at 15:08:21, AnilKumar, Chimata wrote:
> Add pinctrl and d_can device tree data to AM33XX family of devices.
> First two patches add support for pinctrl DT data and third one
> adds dcan DT data.
>
> Reason behind combining these patches is to apply cleanly on
> linux-omap tree, because these are sequential patches.
>
> These patches were tested on AM335x-Bone, AM335x-EVM and based
> on linux-omap:master with this patch
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg74393.html
>
If there are no changes in this patch series ACK from
reviewers (esp. Tony, koen and Marc) will help.
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices
2012-09-07 5:30 ` [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices AnilKumar, Chimata
@ 2012-09-07 8:37 ` Benoit Cousson
2012-09-07 17:01 ` Tony Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Benoit Cousson @ 2012-09-07 8:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Anil,
On 09/07/2012 07:30 AM, AnilKumar, Chimata wrote:
> On Thu, Sep 06, 2012 at 15:08:21, AnilKumar, Chimata wrote:
>> Add pinctrl and d_can device tree data to AM33XX family of devices.
>> First two patches add support for pinctrl DT data and third one
>> adds dcan DT data.
>>
>> Reason behind combining these patches is to apply cleanly on
>> linux-omap tree, because these are sequential patches.
>>Yes,
>> These patches were tested on AM335x-Bone, AM335x-EVM and based
>> on linux-omap:master with this patch
>> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg74393.html
>>
>
> If there are no changes in this patch series ACK from
> reviewers (esp. Tony, koen and Marc) will help.
Yes, indeed. The series looks good to me, but it will be nice to get
some acks from people who commented previous revision.
Regards,
Benoit
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices
2012-09-07 8:37 ` Benoit Cousson
@ 2012-09-07 17:01 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2012-09-07 17:01 UTC (permalink / raw)
To: linux-arm-kernel
* Benoit Cousson <b-cousson@ti.com> [120907 01:38]:
> Hi Anil,
>
> On 09/07/2012 07:30 AM, AnilKumar, Chimata wrote:
> > On Thu, Sep 06, 2012 at 15:08:21, AnilKumar, Chimata wrote:
> >> Add pinctrl and d_can device tree data to AM33XX family of devices.
> >> First two patches add support for pinctrl DT data and third one
> >> adds dcan DT data.
> >>
> >> Reason behind combining these patches is to apply cleanly on
> >> linux-omap tree, because these are sequential patches.
> >>Yes,
> >> These patches were tested on AM335x-Bone, AM335x-EVM and based
> >> on linux-omap:master with this patch
> >> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg74393.html
> >>
> >
> > If there are no changes in this patch series ACK from
> > reviewers (esp. Tony, koen and Marc) will help.
>
> Yes, indeed. The series looks good to me, but it will be nice to get
> some acks from people who commented previous revision.
Acked two of them, but there's still some gpio-leds.c discussion
going on that should be resolved first.
Tony
^ permalink raw reply [flat|nested] 10+ messages in thread