From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] hwmon: Add devicetree bindings to gpio-fan
Date: Mon, 10 Sep 2012 17:28:14 +0200 [thread overview]
Message-ID: <20120910152814.GA6050@lunn.ch> (raw)
In-Reply-To: <1347285112-13542-2-git-send-email-jm@lentin.co.uk>
On Mon, Sep 10, 2012 at 02:51:51PM +0100, Jamie Lentin wrote:
> Allow a gpio-fan to be defined in devicetree, see binding documentation
> for details.
>
> Changes since V1:-
> * Don't hide return codes [Guenter Roeck]
> * Remove typecast noise [Guenter Roeck]
> * Use of_find_property instead of counting u32s [Guenter Roeck]
> * Don't count GPIOs twice [Andrew Lunn]
> * Use of_prop_next_u32 to get records in a more obvious fashion
> * Use CONFIG_OF_GPIO instead of CONFIG_OF
> * Apply __devinitdata to of_gpio_fan_match [Andrew Lunn]
>
> Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
> ---
> .../devicetree/bindings/gpio/gpio-fan.txt | 25 +++++
> drivers/hwmon/gpio-fan.c | 116 ++++++++++++++++++++
> 2 files changed, 141 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-fan.txt
Hi Jamie
Thanks for addressing all the issues raised. However...
Anything before the --- ends up in the changelog entry. Anything
afterwards does not.
The changes you made to address review comments is not something for
the changelog, so Changes since V1:- should be after the --- .
There is more detail in Documentation/SubmittingPatches
Andrew
next prev parent reply other threads:[~2012-09-10 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 16:34 [PATCH 0/2] hwmon: kirkwood: Add DT bindings to gpio-fan for DNS-32[05] Jamie Lentin
2012-09-07 16:34 ` [PATCH 1/2] hwmon: Add devicetree bindings to gpio-fan Jamie Lentin
2012-09-07 18:36 ` Guenter Roeck
2012-09-08 7:32 ` Andrew Lunn
2012-09-07 16:34 ` [PATCH 2/2] ARM: kirkwood: Use devicetree to define DNS-32[05] fan Jamie Lentin
2012-09-07 21:23 ` Andrew Lunn
2012-09-10 13:51 ` [PATCH V2 0/2] hwmon: kirkwood: Add DT bindings to gpio-fan for DNS-32[05] Jamie Lentin
2012-09-10 13:51 ` [PATCH V2 1/2] hwmon: Add devicetree bindings to gpio-fan Jamie Lentin
2012-09-10 15:28 ` Andrew Lunn [this message]
2012-09-10 16:04 ` Jamie Lentin
2012-09-10 18:15 ` Jason Cooper
2012-09-10 18:49 ` Guenter Roeck
2012-09-14 16:07 ` [PATCH V3 " Jamie Lentin
2012-09-15 2:28 ` Guenter Roeck
2012-09-15 3:16 ` Jason Cooper
2012-09-10 13:51 ` [PATCH V2 2/2] ARM: kirkwood: Use devicetree to define DNS-32[05] fan Jamie Lentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910152814.GA6050@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).