From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: avoid undef on ARCH_HAS_READ_CURRENT_TIMER
Date: Tue, 11 Sep 2012 19:01:00 +0100 [thread overview]
Message-ID: <20120911180100.GS13739@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1347380341-28145-1-git-send-email-cyril@ti.com>
On Tue, Sep 11, 2012 at 12:19:00PM -0400, Cyril Chemparathy wrote:
> With the inclusion of asm-generic/timex.h, the ARM arch timer implementation
> breaks on build. This is because asm/arch_timer.h now defines
> ARCH_HAS_READ_CURRENT_TIMER, only to have this macro undefined by the
> subsequent inclusion of asm-generic/timex.h.
>
> This patch fixes the problem in asm/timex.h by including asm-generic/timex.h
> early, and by defining get_cycles even earlier.
>
> This patch has been tested against linux-next-20120910, both with and without
> arch timer support.
Given the complexity this introduces, just for the sake of using one
thing from asm-generic/timex.h:
typedef unsigned long cycles_t;
it seems utterly pointless to use the asm-generic version at all,
especially if we have to play games to work around what it's doing.
What this means is one of two things. Either we should not be using
asm-generic/timex.h, or asm-generic/timex.h as currently exists is
broken.
next prev parent reply other threads:[~2012-09-11 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 16:19 [PATCH] ARM: avoid undef on ARCH_HAS_READ_CURRENT_TIMER Cyril Chemparathy
2012-09-11 16:25 ` Will Deacon
2012-09-11 16:59 ` Cyril Chemparathy
2012-09-11 17:20 ` Will Deacon
2012-09-11 17:28 ` Cyril Chemparathy
2012-09-11 17:53 ` Will Deacon
2012-09-11 18:31 ` Cyril Chemparathy
2012-09-11 19:28 ` Russell King - ARM Linux
2012-09-11 19:41 ` Cyril Chemparathy
2012-09-11 18:01 ` Russell King - ARM Linux [this message]
2012-09-11 18:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911180100.GS13739@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).