From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 18/23] i2c: omap: remove redundant status read
Date: Tue, 11 Sep 2012 23:54:41 +0200 [thread overview]
Message-ID: <20120911215441.GC27031@pengutronix.de> (raw)
In-Reply-To: <1347356538-23835-19-git-send-email-shubhrajyoti@ti.com>
On Tue, Sep 11, 2012 at 03:12:13PM +0530, Shubhrajyoti D wrote:
> Remove the redundant read of the status register.
Commit message is just repeating the subject.
Why was the read there and why can it be removed now?
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 5d4bad4..498a462 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -946,7 +946,6 @@ omap_i2c_isr(int this_irq, void *dev_id)
> num_bytes = dev->buf_len;
>
> ret = omap_i2c_transmit_data(dev, num_bytes, true);
> - stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
> if (ret < 0)
> goto out;
>
> @@ -962,7 +961,6 @@ omap_i2c_isr(int this_irq, void *dev_id)
> num_bytes = dev->threshold;
>
> ret = omap_i2c_transmit_data(dev, num_bytes, false);
> - stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
> if (ret < 0)
> goto out;
>
> --
> 1.7.5.4
>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120911/ef823e8b/attachment-0001.sig>
next prev parent reply other threads:[~2012-09-11 21:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 9:41 [PATCHv7 00/23]I2C big cleanup Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 01/23] i2c: omap: switch to devm_* API Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 02/23] i2c: omap: simplify num_bytes handling Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 03/23] i2c: omap: decrease indentation level on data handling Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 04/23] i2c: omap: add blank lines Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 05/23] i2c: omap: simplify omap_i2c_ack_stat() Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 06/23] i2c: omap: split out [XR]DR and [XR]RDY Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 07/23] i2c: omap: improve i462 errata handling Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 08/23] i2c: omap: re-factor receive/transmit data loop Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 09/23] i2c: omap: switch over to do {} while loop Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 10/23] i2c: omap: ack IRQ in parts Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 11/23] i2c: omap: switch to platform_get_irq() Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 12/23] i2c: omap: bus: add a receiver flag Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 13/23] i2c: omap: simplify errata check Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 14/23] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 15/23] i2c: omap: simplify IRQ exit path Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 16/23] i2c: omap: resize fifos before each message Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 17/23] i2c: omap: get rid of the "complete" label Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 18/23] i2c: omap: remove redundant status read Shubhrajyoti D
2012-09-11 21:54 ` Wolfram Sang [this message]
2012-09-12 6:51 ` Shubhrajyoti
2012-09-11 9:42 ` [PATCHv7 19/23] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
2012-09-11 21:53 ` Wolfram Sang
2012-09-12 6:42 ` Shubhrajyoti
2012-09-11 9:42 ` [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support Shubhrajyoti D
2012-09-11 21:51 ` Wolfram Sang
2012-09-12 6:25 ` Shubhrajyoti
2012-09-12 11:51 ` Wolfram Sang
2012-09-11 9:42 ` [PATCHv7 21/23] i2c: omap: remove unnecessary pm_runtime_suspended check Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 22/23] i2c: omap: switch over to autosuspend API Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 23/23] i2c: omap: sanitize exit path Shubhrajyoti D
2012-09-11 10:18 ` [PATCHv7 00/23]I2C big cleanup Shubhrajyoti
2012-09-11 12:05 ` Felipe Balbi
2012-09-11 22:00 ` Wolfram Sang
2012-09-12 10:11 ` Shubhrajyoti
2012-09-12 10:18 ` Wolfram Sang
2012-09-12 13:44 ` Wolfram Sang
2012-09-12 14:40 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911215441.GC27031@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).