From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: suspend: use flush range instead of flush all
Date: Wed, 12 Sep 2012 09:54:45 +0100 [thread overview]
Message-ID: <20120912085445.GW13739@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAMQu2gwK+TP+7qQG0cET04y7+BYn--5UwkVuffOUu0kuv8Ps6A@mail.gmail.com>
On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote:
> On Wed, Sep 12, 2012 at 12:48 PM, wzch <wzch@marvell.com> wrote:
> > void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr)
> > {
> > + u32 *ptr_orig = ptr;
> > *save_ptr = virt_to_phys(ptr);
> >
> > /* This must correspond to the LDM in cpu_resume() assembly */
> > @@ -26,7 +27,8 @@ void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr)
> >
> > cpu_do_suspend(ptr);
> >
> > - flush_cache_all();
> Lorenzo's patch was limiting above flush to local cache (LOUs) instead
> of dropping it completely.
Err, that is wrong. Normally, when CPUs go into suspend, the L1 cache is
lost entirely. This is the only flush which many CPUs see of the L1
cache.
So removing this flush _will_ break suspend to RAM on existing CPUs.
next prev parent reply other threads:[~2012-09-12 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347434328-7207-1-git-send-email-wzch@marvell.com>
2012-09-12 7:43 ` [PATCH] ARM: suspend: use flush range instead of flush all Shilimkar, Santosh
2012-09-12 8:54 ` Russell King - ARM Linux [this message]
2012-09-12 9:10 ` Shilimkar, Santosh
2012-09-12 9:46 ` Russell King - ARM Linux
2012-09-12 9:57 ` Shilimkar, Santosh
2012-09-13 2:20 ` Raul Xiong
2012-09-13 8:52 ` Russell King - ARM Linux
2012-09-12 8:58 ` Lorenzo Pieralisi
2012-09-12 9:20 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912085445.GW13739@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).