From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T
Date: Wed, 12 Sep 2012 14:19:18 +0100 [thread overview]
Message-ID: <20120912131918.GD21823@arm.com> (raw)
In-Reply-To: <CAMQu2gzpiZ8Qa8eGprCscmhFa1zW4Bb4ZEVR=e56tXBSE1pGWQ@mail.gmail.com>
On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote:
> On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote:
> >
> > On 9/12/2012 1:50 AM, R Sricharan wrote:
> >>
> >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig,
> >> the feature is not getting selected.
> >> Adding a string description in the Kconfig resolves this.
> >>
> >> But not sure if this is the right way to fix this.
> >>
> >
> > Shouldn't you be selecting this in your 64-bit dma address capable arch
> > instead?
> >
> Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens
> in the arch which needs it. Since this option was made as simple bool,
> looks like because of some KCONFIG magic, it was not getting selected.
> Adding some help text does fix the issue and thats is the patch all about.
Are you sure you select this explicitly in Kconfig? It should not depend
on a description.
What I understood from the initial email was that this option was only
added to the defconfig but ignored by the kernel as it's not a user
selectable option (unless you add some text).
--
Catalin
next prev parent reply other threads:[~2012-09-12 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 5:50 [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T R Sricharan
2012-09-12 12:46 ` Cyril Chemparathy
2012-09-12 12:56 ` Catalin Marinas
2012-09-12 12:57 ` Shilimkar, Santosh
2012-09-12 13:19 ` Catalin Marinas [this message]
2012-09-12 13:25 ` Shilimkar, Santosh
2012-09-12 13:29 ` R, Sricharan
2012-09-12 13:20 ` R, Sricharan
2012-09-12 14:55 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912131918.GD21823@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).