* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T @ 2012-09-12 5:50 R Sricharan 2012-09-12 12:46 ` Cyril Chemparathy 0 siblings, 1 reply; 9+ messages in thread From: R Sricharan @ 2012-09-12 5:50 UTC (permalink / raw) To: linux-arm-kernel Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected. Adding a string description in the Kconfig resolves this. But not sure if this is the right way to fix this. Signed-off-by: R Sricharan <r.sricharan@ti.com> Cc: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/mm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 101b968..90c5ea4 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -601,7 +601,7 @@ config ARCH_PHYS_ADDR_T_64BIT def_bool ARM_LPAE config ARCH_DMA_ADDR_T_64BIT - bool + bool "64bit capable DMA device" config ARM_THUMB bool "Support Thumb user binaries" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 5:50 [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T R Sricharan @ 2012-09-12 12:46 ` Cyril Chemparathy 2012-09-12 12:56 ` Catalin Marinas 2012-09-12 12:57 ` Shilimkar, Santosh 0 siblings, 2 replies; 9+ messages in thread From: Cyril Chemparathy @ 2012-09-12 12:46 UTC (permalink / raw) To: linux-arm-kernel On 9/12/2012 1:50 AM, R Sricharan wrote: > Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, > the feature is not getting selected. > Adding a string description in the Kconfig resolves this. > > But not sure if this is the right way to fix this. > Shouldn't you be selecting this in your 64-bit dma address capable arch instead? > Signed-off-by: R Sricharan <r.sricharan@ti.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > --- > arch/arm/mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index 101b968..90c5ea4 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -601,7 +601,7 @@ config ARCH_PHYS_ADDR_T_64BIT > def_bool ARM_LPAE > > config ARCH_DMA_ADDR_T_64BIT > - bool > + bool "64bit capable DMA device" > > config ARM_THUMB > bool "Support Thumb user binaries" > -- Thanks - Cyril ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 12:46 ` Cyril Chemparathy @ 2012-09-12 12:56 ` Catalin Marinas 2012-09-12 12:57 ` Shilimkar, Santosh 1 sibling, 0 replies; 9+ messages in thread From: Catalin Marinas @ 2012-09-12 12:56 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 12, 2012 at 01:46:18PM +0100, Cyril Chemparathy wrote: > On 9/12/2012 1:50 AM, R Sricharan wrote: > > Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, > > the feature is not getting selected. > > Adding a string description in the Kconfig resolves this. > > > > But not sure if this is the right way to fix this. > > Shouldn't you be selecting this in your 64-bit dma address capable arch > instead? Yes, that's how it was meant to be used. -- Catalin ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 12:46 ` Cyril Chemparathy 2012-09-12 12:56 ` Catalin Marinas @ 2012-09-12 12:57 ` Shilimkar, Santosh 2012-09-12 13:19 ` Catalin Marinas 2012-09-12 13:20 ` R, Sricharan 1 sibling, 2 replies; 9+ messages in thread From: Shilimkar, Santosh @ 2012-09-12 12:57 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote: > > On 9/12/2012 1:50 AM, R Sricharan wrote: >> >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, >> the feature is not getting selected. >> Adding a string description in the Kconfig resolves this. >> >> But not sure if this is the right way to fix this. >> > > Shouldn't you be selecting this in your 64-bit dma address capable arch > instead? > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens in the arch which needs it. Since this option was made as simple bool, looks like because of some KCONFIG magic, it was not getting selected. Adding some help text does fix the issue and thats is the patch all about. Regards Santosh ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 12:57 ` Shilimkar, Santosh @ 2012-09-12 13:19 ` Catalin Marinas 2012-09-12 13:25 ` Shilimkar, Santosh 2012-09-12 13:20 ` R, Sricharan 1 sibling, 1 reply; 9+ messages in thread From: Catalin Marinas @ 2012-09-12 13:19 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: > On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote: > > > > On 9/12/2012 1:50 AM, R Sricharan wrote: > >> > >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, > >> the feature is not getting selected. > >> Adding a string description in the Kconfig resolves this. > >> > >> But not sure if this is the right way to fix this. > >> > > > > Shouldn't you be selecting this in your 64-bit dma address capable arch > > instead? > > > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens > in the arch which needs it. Since this option was made as simple bool, > looks like because of some KCONFIG magic, it was not getting selected. > Adding some help text does fix the issue and thats is the patch all about. Are you sure you select this explicitly in Kconfig? It should not depend on a description. What I understood from the initial email was that this option was only added to the defconfig but ignored by the kernel as it's not a user selectable option (unless you add some text). -- Catalin ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 13:19 ` Catalin Marinas @ 2012-09-12 13:25 ` Shilimkar, Santosh 2012-09-12 13:29 ` R, Sricharan 0 siblings, 1 reply; 9+ messages in thread From: Shilimkar, Santosh @ 2012-09-12 13:25 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 12, 2012 at 6:49 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: >> On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote: >> > >> > On 9/12/2012 1:50 AM, R Sricharan wrote: >> >> >> >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, >> >> the feature is not getting selected. >> >> Adding a string description in the Kconfig resolves this. >> >> >> >> But not sure if this is the right way to fix this. >> >> >> > >> > Shouldn't you be selecting this in your 64-bit dma address capable arch >> > instead? >> > >> Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens >> in the arch which needs it. Since this option was made as simple bool, >> looks like because of some KCONFIG magic, it was not getting selected. >> Adding some help text does fix the issue and thats is the patch all about. > > Are you sure you select this explicitly in Kconfig? It should not depend > on a description. > You are right. > What I understood from the initial email was that this option was only > added to the defconfig but ignored by the kernel as it's not a user > selectable option (unless you add some text). > That's right. Explicit KCONFIG select should work. Regards Santosh ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 13:25 ` Shilimkar, Santosh @ 2012-09-12 13:29 ` R, Sricharan 0 siblings, 0 replies; 9+ messages in thread From: R, Sricharan @ 2012-09-12 13:29 UTC (permalink / raw) To: linux-arm-kernel Hi, On Wed, Sep 12, 2012 at 6:55 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Wed, Sep 12, 2012 at 6:49 PM, Catalin Marinas > <catalin.marinas@arm.com> wrote: >> On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: >>> On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote: >>> > >>> > On 9/12/2012 1:50 AM, R Sricharan wrote: >>> >> >>> >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, >>> >> the feature is not getting selected. >>> >> Adding a string description in the Kconfig resolves this. >>> >> >>> >> But not sure if this is the right way to fix this. >>> >> >>> > >>> > Shouldn't you be selecting this in your 64-bit dma address capable arch >>> > instead? >>> > >>> Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens >>> in the arch which needs it. Since this option was made as simple bool, >>> looks like because of some KCONFIG magic, it was not getting selected. >>> Adding some help text does fix the issue and thats is the patch all about. >> >> Are you sure you select this explicitly in Kconfig? It should not depend >> on a description. >> > You are right. > >> What I understood from the initial email was that this option was only >> added to the defconfig but ignored by the kernel as it's not a user >> selectable option (unless you add some text). >> > That's right. Explicit KCONFIG select should work. yes. It works when enabled in arch/KCONFIG. Thanks. This patch is not needed then. Thanks, Sricharan ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 12:57 ` Shilimkar, Santosh 2012-09-12 13:19 ` Catalin Marinas @ 2012-09-12 13:20 ` R, Sricharan 2012-09-12 14:55 ` Russell King - ARM Linux 1 sibling, 1 reply; 9+ messages in thread From: R, Sricharan @ 2012-09-12 13:20 UTC (permalink / raw) To: linux-arm-kernel Hi, On Wed, Sep 12, 2012 at 6:27 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote: >> >> On 9/12/2012 1:50 AM, R Sricharan wrote: >>> >>> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, >>> the feature is not getting selected. >>> Adding a string description in the Kconfig resolves this. >>> >>> But not sure if this is the right way to fix this. >>> >> >> Shouldn't you be selecting this in your 64-bit dma address capable arch >> instead? >> > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens > in the arch which needs it. Since this option was made as simple bool, > looks like because of some KCONFIG magic, it was not getting selected. > Adding some help text does fix the issue and thats is the patch all about. > Correct. So even if you select this in the arch/defconfig, today this option is not getting enabled in the finally generated .config. So by adding this description text, this can really be selected from arch level. Thanks, Sricharan ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T 2012-09-12 13:20 ` R, Sricharan @ 2012-09-12 14:55 ` Russell King - ARM Linux 0 siblings, 0 replies; 9+ messages in thread From: Russell King - ARM Linux @ 2012-09-12 14:55 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 12, 2012 at 06:50:00PM +0530, R, Sricharan wrote: > Hi, > On Wed, Sep 12, 2012 at 6:27 PM, Shilimkar, Santosh > <santosh.shilimkar@ti.com> wrote: > > On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@ti.com> wrote: > >> > >> On 9/12/2012 1:50 AM, R Sricharan wrote: > >>> > >>> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, > >>> the feature is not getting selected. > >>> Adding a string description in the Kconfig resolves this. > >>> > >>> But not sure if this is the right way to fix this. > >>> > >> > >> Shouldn't you be selecting this in your 64-bit dma address capable arch > >> instead? > >> > > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens > > in the arch which needs it. Since this option was made as simple bool, > > looks like because of some KCONFIG magic, it was not getting selected. > > Adding some help text does fix the issue and thats is the patch all about. > > > Correct. So even if you select this in the arch/defconfig, That is correct behaviour. You need an explicit "select DMA_ADDR_64BIT_T" somewhere in a Kconfig file to make it happen. Editing defconfigs is not how we enable these options. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-09-12 14:55 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-12 5:50 [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T R Sricharan 2012-09-12 12:46 ` Cyril Chemparathy 2012-09-12 12:56 ` Catalin Marinas 2012-09-12 12:57 ` Shilimkar, Santosh 2012-09-12 13:19 ` Catalin Marinas 2012-09-12 13:25 ` Shilimkar, Santosh 2012-09-12 13:29 ` R, Sricharan 2012-09-12 13:20 ` R, Sricharan 2012-09-12 14:55 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).