linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: smp_twd: reprogram twd based on clk notifier
Date: Wed, 12 Sep 2012 13:32:23 -0700	[thread overview]
Message-ID: <20120912203223.3094.5354@nucleus> (raw)
In-Reply-To: <CACRpkda6u7ZL9Rj=6+sMUTMs9zjV10kneUguugTuPziQvS68dQ@mail.gmail.com>

Quoting Linus Walleij (2012-09-12 09:07:51)
> On Wed, Sep 12, 2012 at 6:05 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Fri, Sep 7, 2012 at 10:19 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> >
> >> -static struct notifier_block twd_cpufreq_nb = {
> >> -       .notifier_call = twd_cpufreq_transition,
> >> +static struct notifier_block twd_clk_nb = {
> >> +       .notifier_call = twd_rate_change,
> >
> > But what happens if there is a platform which is now using this through
> > cpufreq and has not yet switched to the common clock? It regresses
> > right, because no notifications arrive anymore? Does it even compile?
> 
> Bah too late in the afternoon :-(
> 
> So the real question is - are we sure that imx6 is the last platform
> migrated to common clock of all those using the CPUfreq scaling
> (this seems to be the last piece) such that
> we don't break anything....
> 

OMAP will break.  My original version of this patch had "HACK:" in the
$subject since it was just a demo of the notifiers.

I'll submit a new version with some #ifdef CONFIG_COMMON_CLK bits ASAP.

Regards,
Mike

> Yours,
> Linus Walleij
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2012-09-12 20:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07  8:19 [PATCH] ARM: smp_twd: reprogram twd based on clk notifier Shawn Guo
2012-09-07 11:59 ` Ulf Hansson
2012-09-07 12:40   ` Shawn Guo
2012-09-07 13:26     ` Ulf Hansson
2012-09-07 21:59       ` Mike Turquette
2012-09-10 11:22         ` Ulf Hansson
2012-09-10 11:27           ` Shilimkar, Santosh
2012-09-12 15:06 ` Shawn Guo
2012-09-12 16:05 ` Linus Walleij
2012-09-12 16:07   ` Linus Walleij
2012-09-12 20:32     ` Mike Turquette [this message]
2012-09-12 22:44       ` [PATCH v2] " Mike Turquette
2012-09-13 12:51         ` Linus Walleij
2012-09-13 21:05           ` Mike Turquette
2012-09-13 13:05         ` Ulf Hansson
2012-09-12 20:47 ` [PATCH] " Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120912203223.3094.5354@nucleus \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).