From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: armadillo5x0: Fix illegal register access
Date: Sat, 15 Sep 2012 20:12:48 +0000 [thread overview]
Message-ID: <201209152012.49195.arnd@arndb.de> (raw)
In-Reply-To: <1347736516-10697-1-git-send-email-festevam@gmail.com>
On Saturday 15 September 2012, Fabio Estevam wrote:
>
> /* set NAND page size to 2k if not configured via boot mode pins */
> - __raw_writel(__raw_readl(MXC_CCM_RCSR) | (1 << 30), MXC_CCM_RCSR);
> + __raw_writel(__raw_readl(mx3_ccm_base + MXC_CCM_RCSR) |
> + (1 << 30), MXC_CCM_RCSR);
>
> /* RTC */
Shouldn't you change both the read and the write here, rather than just the read?
Arnd
prev parent reply other threads:[~2012-09-15 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 19:15 [PATCH] ARM: imx: armadillo5x0: Fix illegal register access Fabio Estevam
2012-09-15 20:12 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209152012.49195.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox