From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage
Date: Mon, 17 Sep 2012 15:14:06 -0700 [thread overview]
Message-ID: <20120917221406.GG11762@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209172207480.16117@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [120917 15:09]:
> On Mon, 17 Sep 2012, Tony Lindgren wrote:
>
> > Commit 7d7e1eba (ARM: OMAP2+: Prepare for irqs.h removal) broke
> > compile for non-omap as include plat/cpu.h was added:
> >
> > drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory
> >
> > This header was indirectly included earlier when SPARSE_IRQ was not
> > set, but does not exist on most platforms.
> >
> > Fix the problem by removing the cpu_is_omap usage that should
> > not exist in drivers at all. We can do this by adding proper
> > clock aliases for the twl-core.c drivers, and drop separate
> > handling for cases when clock framework is not available as
> > the behaviour will stay the same.
> >
> > Note that we need to add a platform device to avoid using the
> > i2c provided names that may be different on various omaps.
> >
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Olof Johansson <olof@lixom.net>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> > ---
> >
> > Samuel, I'd like to queue this via arm-soc as that's where I have
> > the breaking patch is if this patch is OK with you.
>
> It would be ideal if I could queue this one, due to the clock dependency.
> Still hoping that we can get the CCF conversion patches in for 3.7.
We need to queue this ASAP and before other patches to fix the
build breakage in linux next. Then you can merge in that commit
too, does that work for you?
Tony
next prev parent reply other threads:[~2012-09-17 22:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 20:29 [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage Tony Lindgren
2012-09-17 20:43 ` Arnd Bergmann
2012-09-17 22:08 ` Paul Walmsley
2012-09-17 22:14 ` Tony Lindgren [this message]
2012-09-17 22:24 ` Paul Walmsley
2012-09-17 22:26 ` Tony Lindgren
2012-09-18 2:30 ` Tony Lindgren
2012-09-17 22:59 ` Samuel Ortiz
2012-09-18 4:51 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917221406.GG11762@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).