From: richard.zhao@freescale.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq
Date: Wed, 19 Sep 2012 09:32:49 +0800 [thread overview]
Message-ID: <20120919013248.GG13530@b20223-02.ap.freescale.net> (raw)
In-Reply-To: <201209190330.41648.marex@denx.de>
On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> Dear Richard Zhao,
>
> You know, commit message would be nice to have.
Yes, but for this one, the title shows obviously what it changed,
doesn't it?
Thanks
Richard
>
> > Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
>
> Otherwise
>
> Reviewed-by: Marek Vasut <marex@denx.de>
>
> > ---
> > drivers/usb/chipidea/core.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 307651b..0942b9b 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct
> > platform_device *pdev) }
> >
> > platform_set_drvdata(pdev, ci);
> > - ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
> > - ci);
> > + ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
> > + ci->platdata->name, ci);
> > if (ret)
> > goto stop;
> >
> > @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct
> > platform_device *pdev) flush_workqueue(ci->wq);
> > destroy_workqueue(ci->wq);
> > device_remove_file(ci->dev, &dev_attr_role);
> > - free_irq(ci->irq, ci);
> > ci_role_stop(ci);
> >
> > return 0;
>
> Best regards,
> Marek Vasut
>
next prev parent reply other threads:[~2012-09-19 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 1:20 [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq Richard Zhao
2012-09-19 1:30 ` Marek Vasut
2012-09-19 1:32 ` Richard Zhao [this message]
2012-09-19 12:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919013248.GG13530@b20223-02.ap.freescale.net \
--to=richard.zhao@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox