[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[Richard Zhao]

Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
---
 drivers/usb/chipidea/core.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 307651b..0942b9b 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
 	}
 
 	platform_set_drvdata(pdev, ci);
-	ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
-			  ci);
+	ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
+				ci->platdata->name, ci);
 	if (ret)
 		goto stop;
 
@@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct platform_device *pdev)
 	flush_workqueue(ci->wq);
 	destroy_workqueue(ci->wq);
 	device_remove_file(ci->dev, &dev_attr_role);
-	free_irq(ci->irq, ci);
 	ci_role_stop(ci);
 
 	return 0;
-- 
1.7.9.5

[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[Marek Vasut]

Dear Richard Zhao,

You know, commit message would be nice to have.

> Signed-off-by: Richard Zhao <richard.zhao@freescale.com>

Otherwise

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/usb/chipidea/core.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 307651b..0942b9b 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct
> platform_device *pdev) }
> 
>  	platform_set_drvdata(pdev, ci);
> -	ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
> -			  ci);
> +	ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
> +				ci->platdata->name, ci);
>  	if (ret)
>  		goto stop;
> 
> @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct
> platform_device *pdev) flush_workqueue(ci->wq);
>  	destroy_workqueue(ci->wq);
>  	device_remove_file(ci->dev, &dev_attr_role);
> -	free_irq(ci->irq, ci);
>  	ci_role_stop(ci);
> 
>  	return 0;

Best regards,
Marek Vasut

[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[Richard Zhao]

On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> Dear Richard Zhao,
> 
> You know, commit message would be nice to have.
Yes, but for this one, the title shows obviously what it changed,
doesn't it?

Thanks
Richard
> 
> > Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
> 
> Otherwise
> 
> Reviewed-by: Marek Vasut <marex@denx.de>
> 
> > ---
> >  drivers/usb/chipidea/core.c |    5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 307651b..0942b9b 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct
> > platform_device *pdev) }
> > 
> >  	platform_set_drvdata(pdev, ci);
> > -	ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
> > -			  ci);
> > +	ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
> > +				ci->platdata->name, ci);
> >  	if (ret)
> >  		goto stop;
> > 
> > @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct
> > platform_device *pdev) flush_workqueue(ci->wq);
> >  	destroy_workqueue(ci->wq);
> >  	device_remove_file(ci->dev, &dev_attr_role);
> > -	free_irq(ci->irq, ci);
> >  	ci_role_stop(ci);
> > 
> >  	return 0;
> 
> Best regards,
> Marek Vasut
> 

[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[Felipe Balbi]

On Wed, Sep 19, 2012 at 09:32:49AM +0800, Richard Zhao wrote:
> On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> > Dear Richard Zhao,
> > 
> > You know, commit message would be nice to have.
> Yes, but for this one, the title shows obviously what it changed,
> doesn't it?

Alex has the the final word, but I'm also very picky about commit
messages. IMHO, all patches should have commit message, even if it
sounds obvious.

For example, you could let us know the reasoning behind converting to
devm_request_irq().

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120919/cd4cf30e/attachment.sig>