From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Wed, 19 Sep 2012 03:30:41 +0200 Subject: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq In-Reply-To: <1348017626-6570-1-git-send-email-richard.zhao@freescale.com> References: <1348017626-6570-1-git-send-email-richard.zhao@freescale.com> Message-ID: <201209190330.41648.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Richard Zhao, You know, commit message would be nice to have. > Signed-off-by: Richard Zhao Otherwise Reviewed-by: Marek Vasut > --- > drivers/usb/chipidea/core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 307651b..0942b9b 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct > platform_device *pdev) } > > platform_set_drvdata(pdev, ci); > - ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name, > - ci); > + ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED, > + ci->platdata->name, ci); > if (ret) > goto stop; > > @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct > platform_device *pdev) flush_workqueue(ci->wq); > destroy_workqueue(ci->wq); > device_remove_file(ci->dev, &dev_attr_role); > - free_irq(ci->irq, ci); > ci_role_stop(ci); > > return 0; Best regards, Marek Vasut