* [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq
@ 2012-09-19 1:20 Richard Zhao
2012-09-19 1:30 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Richard Zhao @ 2012-09-19 1:20 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
---
drivers/usb/chipidea/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 307651b..0942b9b 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, ci);
- ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
- ci);
+ ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
+ ci->platdata->name, ci);
if (ret)
goto stop;
@@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct platform_device *pdev)
flush_workqueue(ci->wq);
destroy_workqueue(ci->wq);
device_remove_file(ci->dev, &dev_attr_role);
- free_irq(ci->irq, ci);
ci_role_stop(ci);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq
2012-09-19 1:20 [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq Richard Zhao
@ 2012-09-19 1:30 ` Marek Vasut
2012-09-19 1:32 ` Richard Zhao
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2012-09-19 1:30 UTC (permalink / raw)
To: linux-arm-kernel
Dear Richard Zhao,
You know, commit message would be nice to have.
> Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Otherwise
Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/usb/chipidea/core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 307651b..0942b9b 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct
> platform_device *pdev) }
>
> platform_set_drvdata(pdev, ci);
> - ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
> - ci);
> + ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
> + ci->platdata->name, ci);
> if (ret)
> goto stop;
>
> @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct
> platform_device *pdev) flush_workqueue(ci->wq);
> destroy_workqueue(ci->wq);
> device_remove_file(ci->dev, &dev_attr_role);
> - free_irq(ci->irq, ci);
> ci_role_stop(ci);
>
> return 0;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq
2012-09-19 1:30 ` Marek Vasut
@ 2012-09-19 1:32 ` Richard Zhao
2012-09-19 12:01 ` Felipe Balbi
0 siblings, 1 reply; 4+ messages in thread
From: Richard Zhao @ 2012-09-19 1:32 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> Dear Richard Zhao,
>
> You know, commit message would be nice to have.
Yes, but for this one, the title shows obviously what it changed,
doesn't it?
Thanks
Richard
>
> > Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
>
> Otherwise
>
> Reviewed-by: Marek Vasut <marex@denx.de>
>
> > ---
> > drivers/usb/chipidea/core.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 307651b..0942b9b 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct
> > platform_device *pdev) }
> >
> > platform_set_drvdata(pdev, ci);
> > - ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
> > - ci);
> > + ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
> > + ci->platdata->name, ci);
> > if (ret)
> > goto stop;
> >
> > @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct
> > platform_device *pdev) flush_workqueue(ci->wq);
> > destroy_workqueue(ci->wq);
> > device_remove_file(ci->dev, &dev_attr_role);
> > - free_irq(ci->irq, ci);
> > ci_role_stop(ci);
> >
> > return 0;
>
> Best regards,
> Marek Vasut
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq
2012-09-19 1:32 ` Richard Zhao
@ 2012-09-19 12:01 ` Felipe Balbi
0 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2012-09-19 12:01 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 19, 2012 at 09:32:49AM +0800, Richard Zhao wrote:
> On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> > Dear Richard Zhao,
> >
> > You know, commit message would be nice to have.
> Yes, but for this one, the title shows obviously what it changed,
> doesn't it?
Alex has the the final word, but I'm also very picky about commit
messages. IMHO, all patches should have commit message, even if it
sounds obvious.
For example, you could let us know the reasoning behind converting to
devm_request_irq().
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120919/cd4cf30e/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-19 12:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 1:20 [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq Richard Zhao
2012-09-19 1:30 ` Marek Vasut
2012-09-19 1:32 ` Richard Zhao
2012-09-19 12:01 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox