From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq
Date: Wed, 19 Sep 2012 15:01:56 +0300 [thread overview]
Message-ID: <20120919120155.GK3772@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120919013248.GG13530@b20223-02.ap.freescale.net>
On Wed, Sep 19, 2012 at 09:32:49AM +0800, Richard Zhao wrote:
> On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> > Dear Richard Zhao,
> >
> > You know, commit message would be nice to have.
> Yes, but for this one, the title shows obviously what it changed,
> doesn't it?
Alex has the the final word, but I'm also very picky about commit
messages. IMHO, all patches should have commit message, even if it
sounds obvious.
For example, you could let us know the reasoning behind converting to
devm_request_irq().
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120919/cd4cf30e/attachment.sig>
prev parent reply other threads:[~2012-09-19 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 1:20 [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq Richard Zhao
2012-09-19 1:30 ` Marek Vasut
2012-09-19 1:32 ` Richard Zhao
2012-09-19 12:01 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919120155.GK3772@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox