From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mxs: m28evk: Disable OCOTP OUI loading
Date: Wed, 19 Sep 2012 12:50:54 +0200 [thread overview]
Message-ID: <201209191250.54418.marex@denx.de> (raw)
In-Reply-To: <50599F96.5040600@free-electrons.com>
Dear Maxime Ripard,
> Hi Shawn,
>
> Le 19/09/2012 05:15, Shawn Guo a ?crit :
> > On Wed, Sep 19, 2012 at 12:37:17AM +0200, Marek Vasut wrote:
> >> Don't load the FEC MAC address from OCOTP, but use the one supplied
> >> via device tree by U-Boot. This is the preferred way, every DT-capable
> >> bootloader does set up "mac-address" and "local-mac-address" properties
> >> into the DT passed to the kernel.
> >
> > Ok, since you are the maintainer of m28evk board, it could be your call
> > to do so. While for imx28-evk, the kernel at least runs with bootlets
> > which is not DT capable.
> >
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> >> Cc: Shawn Guo <shawn.guo@linaro.org>
> >> ---
> >>
> >> arch/arm/mach-mxs/mach-mxs.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
> >> index 170a930..71d47f5 100644
> >> --- a/arch/arm/mach-mxs/mach-mxs.c
> >> +++ b/arch/arm/mach-mxs/mach-mxs.c
> >> @@ -255,8 +255,6 @@ static void __init imx28_evk_post_init(void)
> >>
> >> static void __init m28evk_init(void)
> >> {
> >>
> >> - update_fec_mac_prop(OUI_DENX);
> >> -
> >
> > Since it's the only user of OUI_DENX, can we remove enum mac_oui
> > completely and make update_fec_mac_prop a fsl specific call?
>
> I have a patch on the way that adds the Crystalfontz OUI for the
> CFA-10049, so it will be quite useful to me in the future.
Do you use U-Boot on that board?
> Maxime
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-19 10:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 22:37 [PATCH] ARM: mxs: m28evk: Disable OCOTP OUI loading Marek Vasut
2012-09-19 3:15 ` Shawn Guo
2012-09-19 9:43 ` Marek Vasut
2012-09-19 10:33 ` Maxime Ripard
2012-09-19 10:50 ` Marek Vasut [this message]
2012-09-19 11:02 ` Maxime Ripard
2012-09-19 11:25 ` Marek Vasut
2012-09-19 11:44 ` Maxime Ripard
2012-09-19 11:51 ` Marek Vasut
2012-09-20 10:47 ` Wolfram Sang
2012-09-20 12:20 ` Marek Vasut
2012-09-20 12:56 ` Wolfram Sang
2012-09-20 13:10 ` Marek Vasut
2012-09-20 13:53 ` Maxime Ripard
2012-09-20 14:24 ` Marek Vasut
2012-09-20 15:10 ` Wolfgang Denk
2012-09-20 15:24 ` Gregory CLEMENT
2012-09-20 15:31 ` Marek Vasut
2012-09-20 17:09 ` Wolfgang Denk
2012-09-20 16:33 ` Marek Vasut
2012-09-20 17:01 ` Maxime Ripard
2012-09-20 17:31 ` Marek Vasut
2012-09-19 14:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209191250.54418.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).