From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: introduce a DTS for Xen unprivileged virtual machines
Date: Thu, 20 Sep 2012 12:18:15 +0100 [thread overview]
Message-ID: <20120920111815.GC2117@linaro.org> (raw)
In-Reply-To: <1348135563.11116.94.camel@hornet>
On Thu, Sep 20, 2012 at 11:06:03AM +0100, Pawel Moll wrote:
> Morning,
>
> On Wed, 2012-09-19 at 18:44 +0100, Stefano Stabellini wrote:
> > +/dts-v1/;
> > +
> > +/include/ "skeleton.dtsi"
>
> Any particular reason to include skeleton? And I think it would be
> better to use #address-cells = <2> and #size-cells = <2>, to be ready
> for LPAE addresses...
>
> > +/ {
> > + model = "XENVM-4.2";
> > + compatible = "xen,xenvm-4.2", "arm,vexpress";
> > + interrupt-parent = <&gic>;
> > +
> > + chosen {
> > + bootargs = "earlyprintk console=hvc0 root=/dev/xvda init=/sbin/init";
> > + };
Are you sure this default command line is appropriate?
I don't normally like to see default command lines unless they really
add something which is crucial for the board to work.
None of those args looks vital to me. They are configuration choices
and should be left up to the user.
Cheers
---Dave
next prev parent reply other threads:[~2012-09-20 11:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 17:44 [PATCH] arm: introduce a DTS for Xen unprivileged virtual machines Stefano Stabellini
2012-09-20 10:06 ` Pawel Moll
2012-09-20 11:18 ` Dave Martin [this message]
2012-09-20 12:02 ` Stefano Stabellini
2012-09-20 21:29 ` Konrad Rzeszutek Wilk
2012-09-21 11:17 ` Stefano Stabellini
2012-09-20 11:39 ` Stefano Stabellini
2012-09-20 11:55 ` Pawel Moll
2012-09-20 12:15 ` Stefano Stabellini
2012-09-20 12:28 ` Marc Zyngier
2012-09-20 13:30 ` Ian Campbell
2012-09-20 13:50 ` Marc Zyngier
2012-09-20 10:17 ` Ian Campbell
2012-09-20 11:56 ` Stefano Stabellini
2012-09-20 12:18 ` Ian Campbell
2012-09-20 12:39 ` Stefano Stabellini
2012-09-20 13:16 ` Ian Campbell
2012-09-20 13:27 ` Arnd Bergmann
2012-09-20 14:11 ` Stefano Stabellini
2012-09-20 14:24 ` Pawel Moll
2012-09-20 10:45 ` [Xen-devel] " David Vrabel
2012-09-20 11:21 ` Dave Martin
2012-09-20 12:04 ` Stefano Stabellini
2012-09-20 12:57 ` Dave Martin
2012-09-20 12:00 ` Stefano Stabellini
2012-09-20 20:26 ` Rob Herring
2012-09-21 11:14 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920111815.GC2117@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).