From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: Add ARM ERRATA 775420 workaround
Date: Fri, 21 Sep 2012 09:29:16 +0100 [thread overview]
Message-ID: <20120921082915.GA21464@arm.com> (raw)
In-Reply-To: <20120921010404.GJ21660@verge.net.au>
On Fri, Sep 21, 2012 at 02:04:04AM +0100, Simon Horman wrote:
> On Thu, Sep 20, 2012 at 10:58:53AM +0100, Catalin Marinas wrote:
> > On 12 September 2012 08:14, Simon Horman <horms@verge.net.au> wrote:
> > > +config ARM_ERRATA_775420
> > > + bool "ARM errata: A data cache maintenance operation which aborts, might lead to deadlock"
> > > + depends on CPU_V7
> > > + help
> > > + This option enables the workaround for the 775420 Cortex-A9 (r2p2,
> > > + r2p6,r2p8,r2p10,r3p0) erratum. In case a date cache maintenance
> > > + operation aborts with MMU exception, it might cause the processor
> > > + deadlock. This workaround puts DSB before executing ISB at the
> > > + beginning of the abort exception handler.
> > > +
> > > endmenu
> >
> > The only case where we can get an abort on cache maintenance is
> > v7_coherent_user_range(). I don't think we have any ISB on the
> > exception handling path for this function, so we could just add the
> > DSB there:
>
> I think that an advantage of Abe-san's implementation is that
> it might to be a bit more robust. But your proposal is certainly
> much cleaner and for that reason I agree it is a good option.
It is more robust but I'm not sure it's worth putting a DSB a any data
abort.
> I've updated the patch, but since the code is now all yours
> I'm unsure if the author should be changed or not.
But the Kconfig entry is yours and it has more lines :)
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2012-09-21 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 7:14 [PATCH 0/2] ARM ERRATA 775420 and 782773 workarounds Simon Horman
2012-09-12 7:14 ` [PATCH 1/2] arm: Add ARM ERRATA 775420 workaround Simon Horman
2012-09-20 9:58 ` Catalin Marinas
2012-09-21 1:04 ` Simon Horman
2012-09-21 8:29 ` Catalin Marinas [this message]
2012-09-12 7:14 ` [PATCH 2/2] arm: Add ARM ERRATA 782773 workaround Simon Horman
2012-09-12 17:59 ` Stephen Boyd
2012-09-13 1:00 ` Simon Horman
2012-09-13 17:20 ` Russell King - ARM Linux
2012-09-20 9:32 ` Catalin Marinas
2012-09-20 9:35 ` Catalin Marinas
2012-09-21 1:00 ` Simon Horman
2012-09-28 1:02 ` Simon Horman
2012-09-28 8:38 ` Catalin Marinas
2012-10-03 2:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921082915.GA21464@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).