* [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
@ 2012-09-25 8:26 yegorslists at googlemail.com
2012-09-25 8:32 ` Russell King - ARM Linux
0 siblings, 1 reply; 4+ messages in thread
From: yegorslists at googlemail.com @ 2012-09-25 8:26 UTC (permalink / raw)
To: linux-arm-kernel
From: Yegor Yefremov <yegorslists@googlemail.com>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
of consistent DMA memory (da8xx frame buffer driver).
Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes:
v2: fix SA1111 breakage
arch/arm/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2f88d8d..b5f242e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1766,8 +1766,8 @@ config HW_PERF_EVENTS
source "mm/Kconfig"
config FORCE_MAX_ZONEORDER
- int "Maximum zone order" if ARCH_SHMOBILE
- range 11 64 if ARCH_SHMOBILE
+ int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
+ range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
default "9" if SA1111
default "11"
help
--
1.7.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
2012-09-25 8:26 [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX yegorslists at googlemail.com
@ 2012-09-25 8:32 ` Russell King - ARM Linux
2012-09-25 8:46 ` Yegor Yefremov
0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2012-09-25 8:32 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> of consistent DMA memory (da8xx frame buffer driver).
Okay, so the patch description says "This needs to be 12 on this platform".
> config FORCE_MAX_ZONEORDER
> - int "Maximum zone order" if ARCH_SHMOBILE
> - range 11 64 if ARCH_SHMOBILE
> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
but you leave it up to the user to select something that may not be
suitable. Wouldn't _just_ adding:
default "12" if SOC_AM33XX
after the "range", and making no other changes be good enough and match
what the patch description says?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
2012-09-25 8:32 ` Russell King - ARM Linux
@ 2012-09-25 8:46 ` Yegor Yefremov
2012-09-25 15:27 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Yegor Yefremov @ 2012-09-25 8:46 UTC (permalink / raw)
To: linux-arm-kernel
On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists at googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>> of consistent DMA memory (da8xx frame buffer driver).
>
> Okay, so the patch description says "This needs to be 12 on this platform".
>
>> config FORCE_MAX_ZONEORDER
>> - int "Maximum zone order" if ARCH_SHMOBILE
>> - range 11 64 if ARCH_SHMOBILE
>> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
>> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>
> but you leave it up to the user to select something that may not be
> suitable. Wouldn't _just_ adding:
>
> default "12" if SOC_AM33XX
>
> after the "range", and making no other changes be good enough and match
> what the patch description says?
You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?
Patch sent.
Yegor
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
2012-09-25 8:46 ` Yegor Yefremov
@ 2012-09-25 15:27 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-09-25 15:27 UTC (permalink / raw)
To: linux-arm-kernel
* Yegor Yefremov <yegor_sub1@visionsystems.de> [120925 01:47]:
> On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> > On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists at googlemail.com wrote:
> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >>
> >> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> >> of consistent DMA memory (da8xx frame buffer driver).
> >
> > Okay, so the patch description says "This needs to be 12 on this platform".
> >
> >> config FORCE_MAX_ZONEORDER
> >> - int "Maximum zone order" if ARCH_SHMOBILE
> >> - range 11 64 if ARCH_SHMOBILE
> >> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
> >> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
> >
> > but you leave it up to the user to select something that may not be
> > suitable. Wouldn't _just_ adding:
> >
> > default "12" if SOC_AM33XX
> >
> > after the "range", and making no other changes be good enough and match
> > what the patch description says?
>
> You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?
Sure.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-25 15:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 8:26 [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX yegorslists at googlemail.com
2012-09-25 8:32 ` Russell King - ARM Linux
2012-09-25 8:46 ` Yegor Yefremov
2012-09-25 15:27 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).