From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx28: Skip OCOTP FEC MAC setup if in DT
Date: Tue, 25 Sep 2012 13:27:51 +0200 [thread overview]
Message-ID: <201209251327.51723.marex@denx.de> (raw)
In-Reply-To: <20120925112431.GB14216@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Tue, Sep 25, 2012 at 01:01:46PM +0200, Marek Vasut wrote:
> > > > np = of_find_compatible_node(from, NULL, "fsl,imx28-
fec");
> > > > if (!np)
> > > >
> > > > return;
> > > >
> > > > +
> > > > + if (of_get_property(np, "local-mac-address", NULL))
> > > > + continue;
> > > > +
> > >
> > > The block should be put after "from" assignment below.
> >
> > Can you please elaborate why would that be necessary?
>
> Without assigning 'np' to 'from', the next iteration of 'for' loop
> will still find the first fec node. Then what's point of 'continue'?
Ewww, you're right.
> Shawn
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-09-25 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 2:40 [PATCH] ARM: mx28: Skip OCOTP FEC MAC setup if in DT Marek Vasut
2012-09-25 5:14 ` Shawn Guo
2012-09-25 11:01 ` Marek Vasut
2012-09-25 11:24 ` Shawn Guo
2012-09-25 11:27 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209251327.51723.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).