linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: i.MX35: Add kernel oftree support
Date: Wed, 26 Sep 2012 12:44:05 +0200	[thread overview]
Message-ID: <20120926104405.GM1322@pengutronix.de> (raw)
In-Reply-To: <1348652369-16649-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi Uwe,

Some points:

- Can we have a more complete devicetree? For the i.MX27 I posted a
  devicetree containing the nodes I need, I wouldn't do that again.
  During creating the i.MX25   devicetree I realized that it's actually
  not much work to make it (nearly) complete. It'll save us from patching
  this file frequently. I am missing nodes at least for the GPT and CCM.
  These are currently not used, but I think we'll need them soon.
- Can we have devicetree clock lookups like Shawn has done for the i.MX6
  (and me for the i.MX25)?

On Wed, Sep 26, 2012 at 11:39:29AM +0200, Uwe Kleine-K?nig wrote:
> +			gpio3: gpio at 0x53fa4000 {
> +				compatible = "fsl,imx35-gpio", "fsl,imx31-gpio";
> +				reg = <0x53fa4000 0x4000>;
> +				interrupts = <56>;
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				interrupt-controller;
> +				#interrupt-cells = <2>;
> +			};
> +
> +			esdhc1: esdhc at 53fb4000 {
> +				compatible = "fsl,mx35-sdhc";
> +				reg = <0x53fb4000 0x4000>;
> +				interrupts = <7>;
> +				status = "disabled";
> +			};

Please add a bus-width = <4> property to the esdhc units. It's the default
right now, but this property might become mandatory.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2012-09-26 10:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  9:39 [PATCH v3] ARM: i.MX35: Add kernel oftree support Uwe Kleine-König
2012-09-26 10:44 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926104405.GM1322@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).