From: cavokz@gmail.com (Domenico Andreoli)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/3] ARM: move ICEDCC uncompress.h to common location
Date: Wed, 26 Sep 2012 23:56:51 +0200 [thread overview]
Message-ID: <20120926215651.GA20405@glitch> (raw)
In-Reply-To: <1348613212-21897-2-git-send-email-swarren@wwwdotorg.org>
On Tue, Sep 25, 2012 at 04:46:50PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Create a common location for uncompress.h, and select the included debug
> macro file using config option.
>
> This does the same for uncompress.h as a recent patch for debug-macro.S,
> which was based on a suggestion by Russell King and implemented by Rob
> Herring.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> arch/arm/Kconfig.debug | 10 ++++
> arch/arm/boot/compressed/misc.c | 64 +---------------------------
> arch/arm/include/debug/icedcc-uncompress.h | 61 ++++++++++++++++++++++++++
> arch/arm/include/debug/none-uncompress.h | 3 +
> 4 files changed, 75 insertions(+), 63 deletions(-)
> create mode 100644 arch/arm/include/debug/icedcc-uncompress.h
> create mode 100644 arch/arm/include/debug/none-uncompress.h
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index b0f3857..0daec3d 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -420,6 +420,16 @@ config DEBUG_LL_INCLUDE
> DEBUG_VEXPRESS_UART0_CA9 || DEBUG_VEXPRESS_UART0_RS1
> default "mach/debug-macro.S"
>
> +config UNCOMPRESS_INCLUDE
> + string
> + default "debug/icedcc-uncompress.h" if DEBUG_ICEDCC
> + default "debug/none-uncompress.h" if ARCH_MULTIPLATFORM || \
> + DEBUG_HIGHBANK_UART || DEBUG_MVEBU_UART || \
> + DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART || \
> + DEBUG_VEXPRESS_UART0_DETECT || DEBUG_VEXPRESS_UART0_CA9 || \
> + DEBUG_VEXPRESS_UART0_RS1
I would ask to add DEBUG_LL_UART_NONE to the or-ed list, which fixes the
build of platforms without mach/uncompress.h and mach/debug-macro.S in
case NONE is selected, but I'm not sure.
If I got the point of Russel right, uncompress.h is not a debug trace and
maybe should not depend on any DEBUG_LL* option?
Regards,
Domenico
next prev parent reply other threads:[~2012-09-26 21:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 22:46 [RFC PATCH 0/3] ARM: uncompress.h multi-platform enablement Stephen Warren
2012-09-25 22:46 ` [RFC PATCH 1/3] ARM: move ICEDCC uncompress.h to common location Stephen Warren
2012-09-26 21:56 ` Domenico Andreoli [this message]
2012-09-27 5:19 ` Stephen Warren
2012-09-25 22:46 ` [RFC PATCH 2/3] ARM: mvebu: restore uncompress.h Stephen Warren
2012-09-25 22:46 ` [RFC PATCH 3/3] ARM: tegra: move debug macros to include/debug Stephen Warren
2012-09-26 10:38 ` [RFC PATCH 0/3] ARM: uncompress.h multi-platform enablement Arnd Bergmann
2012-09-26 10:44 ` Russell King - ARM Linux
2012-09-26 12:05 ` Arnd Bergmann
2012-09-26 13:10 ` Domenico Andreoli
2012-09-26 13:48 ` Tim Bird
2012-09-26 14:17 ` Arnd Bergmann
2012-09-26 14:48 ` Tim Bird
2012-09-26 14:49 ` Arnd Bergmann
2012-09-26 15:10 ` Russell King - ARM Linux
2012-09-26 15:34 ` Stephen Warren
2012-09-28 3:53 ` Nicolas Pitre
2012-09-27 5:37 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926215651.GA20405@glitch \
--to=cavokz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).