* [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led
@ 2012-09-26 23:27 Fabio Estevam
2012-09-26 23:27 ` [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional Fabio Estevam
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Fabio Estevam @ 2012-09-26 23:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led driver
has pinctrl support, so setup the gpio led pin via pinctrl and avoid the
following warning:
leds-gpio leds.2: pins are not configured from the driver
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx53-qsb.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 08948af..5bae4c7 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -60,10 +60,16 @@
697 0x80000000 /* MX53_PAD_EIM_DA12__GPIO3_12 */
701 0x80000000 /* MX53_PAD_EIM_DA13__GPIO3_13 */
868 0x80000000 /* MX53_PAD_PATA_DA_0__GPIO7_6 */
+ >;
+ };
+
+ led_pin_gpio7_7: led_gpio7_7 at 0 {
+ fsl,pins = <
873 0x80000000 /* MX53_PAD_PATA_DA_1__GPIO7_7 */
>;
};
};
+
};
uart1: serial at 53fbc000 {
@@ -216,6 +222,8 @@
leds {
compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&led_pin_gpio7_7>;
user {
label = "Heartbeat";
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional
2012-09-26 23:27 [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Fabio Estevam
@ 2012-09-26 23:27 ` Fabio Estevam
2012-09-27 0:00 ` Marek Vasut
2012-09-26 23:27 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support Fabio Estevam
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Fabio Estevam @ 2012-09-26 23:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Setup the GPIO7_11 pin as interrupt to the DA9053 and also rename the regulator nodes
so that they match with the datasheet.
This allows probing of DA9053 to succeed.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx53-qsb.dts | 54 ++++++++++++++++++++++++++-------------
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 5bae4c7..7be2e82 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -60,6 +60,7 @@
697 0x80000000 /* MX53_PAD_EIM_DA12__GPIO3_12 */
701 0x80000000 /* MX53_PAD_EIM_DA13__GPIO3_13 */
868 0x80000000 /* MX53_PAD_PATA_DA_0__GPIO7_6 */
+ 1149 0x80000000 /* MX53_PAD_GPIO_16__GPIO7_11 */
>;
};
@@ -106,76 +107,93 @@
pmic: dialog at 48 {
compatible = "dlg,da9053-aa", "dlg,da9052";
reg = <0x48>;
+ interrupt-parent = <&gpio7>;
+ interrupts = <11 0x8>; /* low-level active IRQ at GPIO7_11 */
regulators {
- buck0 {
+ buck1_reg: buck1 {
regulator-min-microvolt = <500000>;
regulator-max-microvolt = <2075000>;
+ regulator-always-on;
};
- buck1 {
+ buck2_reg: buck2 {
regulator-min-microvolt = <500000>;
regulator-max-microvolt = <2075000>;
+ regulator-always-on;
};
- buck2 {
+ buck3_reg: buck3 {
regulator-min-microvolt = <925000>;
regulator-max-microvolt = <2500000>;
+ regulator-always-on;
};
- buck3 {
+ buck4_reg: buck4 {
regulator-min-microvolt = <925000>;
regulator-max-microvolt = <2500000>;
+ regulator-always-on;
};
- ldo4 {
+ ldo1_reg: ldo1 {
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
};
- ldo5 {
+ ldo2_reg: ldo2 {
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ ldo3_reg: ldo3 {
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <1800000>;
+ regulator-always-on;
};
- ldo6 {
+ ldo4_reg: ldo4 {
regulator-min-microvolt = <1725000>;
regulator-max-microvolt = <3300000>;
+ regulator-always-on;
};
- ldo7 {
+ ldo5_reg: ldo5 {
regulator-min-microvolt = <1725000>;
regulator-max-microvolt = <3300000>;
+ regulator-always-on;
};
- ldo8 {
+ ldo6_reg: ldo6 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
+ regulator-always-on;
};
- ldo9 {
+ ldo7_reg: ldo7 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
+ regulator-always-on;
};
- ldo10 {
+ ldo8_reg: ldo8 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
+ regulator-always-on;
};
- ldo11 {
+ ldo9_reg: ldo9 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
+ regulator-always-on;
};
- ldo12 {
+ ldo10_reg: ldo10 {
regulator-min-microvolt = <1250000>;
regulator-max-microvolt = <3650000>;
- };
-
- ldo13 {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <3600000>;
+ regulator-always-on;
};
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional
2012-09-26 23:27 ` [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional Fabio Estevam
@ 2012-09-27 0:00 ` Marek Vasut
2012-09-27 0:12 ` Fabio Estevam
0 siblings, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2012-09-27 0:00 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
[...]
> + interrupt-parent = <&gpio7>;
> + interrupts = <11 0x8>; /* low-level
active IRQ at GPIO7_11 */
You mean active-low ? :-)
[...]
What was the conclusion on over-using regulator-always-on ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional
2012-09-27 0:00 ` Marek Vasut
@ 2012-09-27 0:12 ` Fabio Estevam
2012-09-27 0:29 ` Marek Vasut
0 siblings, 1 reply; 11+ messages in thread
From: Fabio Estevam @ 2012-09-27 0:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
On Wed, Sep 26, 2012 at 9:00 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Fabio Estevam,
>
> [...]
>
>> + interrupt-parent = <&gpio7>;
>> + interrupts = <11 0x8>; /* low-level
> active IRQ at GPIO7_11 */
>
> You mean active-low ? :-)
Actually I meant 'active low level-sensitive':
>From Documentation/devicetree/bindings/gpio/fsl-imx-gpio.txt:
The second cell bits[3:0] is used to specify trigger type and level flags:
1 = low-to-high edge triggered.
2 = high-to-low edge triggered.
4 = active high level-sensitive.
8 = active low level-sensitive
> What was the conclusion on over-using regulator-always-on ?
I will be glad to get some suggestions about this.
With the original code the regulators were getting disabled, which
caused some key power supplies to be removed and then system died.
Looking at the mx53qsb/DA9053 board schematics I cannot see any of
these supplies that can be turned-off, and that's why I kept the
'always-on' flag.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional
2012-09-27 0:12 ` Fabio Estevam
@ 2012-09-27 0:29 ` Marek Vasut
2012-09-27 16:18 ` Mark Brown
0 siblings, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2012-09-27 0:29 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
> Hi Marek,
>
> On Wed, Sep 26, 2012 at 9:00 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Fabio Estevam,
> >
> > [...]
> >
> >> + interrupt-parent = <&gpio7>;
> >> + interrupts = <11 0x8>; /*
> >> low-level
> >
> > active IRQ at GPIO7_11 */
> >
> > You mean active-low ? :-)
>
> Actually I meant 'active low level-sensitive':
>
> From Documentation/devicetree/bindings/gpio/fsl-imx-gpio.txt:
>
> The second cell bits[3:0] is used to specify trigger type and level flags:
> 1 = low-to-high edge triggered.
> 2 = high-to-low edge triggered.
> 4 = active high level-sensitive.
> 8 = active low level-sensitive
Thank you, I need to update my knowledge on the imx v7 :)
> > What was the conclusion on over-using regulator-always-on ?
>
> I will be glad to get some suggestions about this.
>
> With the original code the regulators were getting disabled, which
> caused some key power supplies to be removed and then system died.
>
> Looking at the mx53qsb/DA9053 board schematics I cannot see any of
> these supplies that can be turned-off, and that's why I kept the
> 'always-on' flag.
I agree, let's see what Mark has to say. I believe your approach is valid.
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional
2012-09-27 0:29 ` Marek Vasut
@ 2012-09-27 16:18 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2012-09-27 16:18 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 27, 2012 at 02:29:54AM +0200, Marek Vasut wrote:
> Dear Fabio Estevam,
> > Looking at the mx53qsb/DA9053 board schematics I cannot see any of
> > these supplies that can be turned-off, and that's why I kept the
> > 'always-on' flag.
> I agree, let's see what Mark has to say. I believe your approach is valid.
Sorry, I'm missing some context on the discussion here so I'm not usre
what the question is.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support
2012-09-26 23:27 [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Fabio Estevam
2012-09-26 23:27 ` [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional Fabio Estevam
@ 2012-09-26 23:27 ` Fabio Estevam
2012-09-27 0:01 ` Marek Vasut
2012-10-08 9:27 ` Sascha Hauer
2012-09-26 23:59 ` [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Marek Vasut
2012-10-06 15:35 ` Shawn Guo
3 siblings, 2 replies; 11+ messages in thread
From: Fabio Estevam @ 2012-09-26 23:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Add DA9052 regulator support.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 66aa7a6..67620d6 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -142,10 +142,12 @@ CONFIG_GPIO_SYSFS=y
# CONFIG_HWMON is not set
CONFIG_WATCHDOG=y
CONFIG_IMX2_WDT=y
+CONFIG_MFD_DA9052_I2C=y
CONFIG_MFD_MC13XXX_SPI=y
CONFIG_MFD_MC13XXX_I2C=y
CONFIG_REGULATOR=y
CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_REGULATOR_DA9052=y
CONFIG_REGULATOR_MC13783=y
CONFIG_REGULATOR_MC13892=y
CONFIG_MEDIA_SUPPORT=y
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support
2012-09-26 23:27 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support Fabio Estevam
@ 2012-09-27 0:01 ` Marek Vasut
2012-10-08 9:27 ` Sascha Hauer
1 sibling, 0 replies; 11+ messages in thread
From: Marek Vasut @ 2012-09-27 0:01 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Add DA9052 regulator support.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Makes sense
Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> arch/arm/configs/imx_v6_v7_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> b/arch/arm/configs/imx_v6_v7_defconfig index 66aa7a6..67620d6 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -142,10 +142,12 @@ CONFIG_GPIO_SYSFS=y
> # CONFIG_HWMON is not set
> CONFIG_WATCHDOG=y
> CONFIG_IMX2_WDT=y
> +CONFIG_MFD_DA9052_I2C=y
> CONFIG_MFD_MC13XXX_SPI=y
> CONFIG_MFD_MC13XXX_I2C=y
> CONFIG_REGULATOR=y
> CONFIG_REGULATOR_FIXED_VOLTAGE=y
> +CONFIG_REGULATOR_DA9052=y
> CONFIG_REGULATOR_MC13783=y
> CONFIG_REGULATOR_MC13892=y
> CONFIG_MEDIA_SUPPORT=y
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support
2012-09-26 23:27 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support Fabio Estevam
2012-09-27 0:01 ` Marek Vasut
@ 2012-10-08 9:27 ` Sascha Hauer
1 sibling, 0 replies; 11+ messages in thread
From: Sascha Hauer @ 2012-10-08 9:27 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 26, 2012 at 08:27:37PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Add DA9052 regulator support.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks
Sascha
> ---
> arch/arm/configs/imx_v6_v7_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 66aa7a6..67620d6 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -142,10 +142,12 @@ CONFIG_GPIO_SYSFS=y
> # CONFIG_HWMON is not set
> CONFIG_WATCHDOG=y
> CONFIG_IMX2_WDT=y
> +CONFIG_MFD_DA9052_I2C=y
> CONFIG_MFD_MC13XXX_SPI=y
> CONFIG_MFD_MC13XXX_I2C=y
> CONFIG_REGULATOR=y
> CONFIG_REGULATOR_FIXED_VOLTAGE=y
> +CONFIG_REGULATOR_DA9052=y
> CONFIG_REGULATOR_MC13783=y
> CONFIG_REGULATOR_MC13892=y
> CONFIG_MEDIA_SUPPORT=y
> --
> 1.7.9.5
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led
2012-09-26 23:27 [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Fabio Estevam
2012-09-26 23:27 ` [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional Fabio Estevam
2012-09-26 23:27 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support Fabio Estevam
@ 2012-09-26 23:59 ` Marek Vasut
2012-10-06 15:35 ` Shawn Guo
3 siblings, 0 replies; 11+ messages in thread
From: Marek Vasut @ 2012-09-26 23:59 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led
> driver has pinctrl support, so setup the gpio led pin via pinctrl and
> avoid the following warning:
>
> leds-gpio leds.2: pins are not configured from the driver
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> arch/arm/boot/dts/imx53-qsb.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx53-qsb.dts
> b/arch/arm/boot/dts/imx53-qsb.dts index 08948af..5bae4c7 100644
> --- a/arch/arm/boot/dts/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/imx53-qsb.dts
> @@ -60,10 +60,16 @@
> 697 0x80000000 /*
MX53_PAD_EIM_DA12__GPIO3_12 */
> 701 0x80000000 /*
MX53_PAD_EIM_DA13__GPIO3_13 */
> 868 0x80000000 /*
MX53_PAD_PATA_DA_0__GPIO7_6 */
> + >;
> + };
> +
> + led_pin_gpio7_7: led_gpio7_7 at 0 {
> + fsl,pins = <
> 873 0x80000000 /*
MX53_PAD_PATA_DA_1__GPIO7_7 */
>
> >;
>
> };
> };
> +
> };
>
> uart1: serial at 53fbc000 {
> @@ -216,6 +222,8 @@
>
> leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&led_pin_gpio7_7>;
>
> user {
> label = "Heartbeat";
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led
2012-09-26 23:27 [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Fabio Estevam
` (2 preceding siblings ...)
2012-09-26 23:59 ` [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Marek Vasut
@ 2012-10-06 15:35 ` Shawn Guo
3 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2012-10-06 15:35 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 26, 2012 at 08:27:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led driver
> has pinctrl support, so setup the gpio led pin via pinctrl and avoid the
> following warning:
>
> leds-gpio leds.2: pins are not configured from the driver
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Queued first 2 patches for 3.8, and leave patch #3 to Sascha.
Shawn
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-10-08 9:27 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 23:27 [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Fabio Estevam
2012-09-26 23:27 ` [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional Fabio Estevam
2012-09-27 0:00 ` Marek Vasut
2012-09-27 0:12 ` Fabio Estevam
2012-09-27 0:29 ` Marek Vasut
2012-09-27 16:18 ` Mark Brown
2012-09-26 23:27 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support Fabio Estevam
2012-09-27 0:01 ` Marek Vasut
2012-10-08 9:27 ` Sascha Hauer
2012-09-26 23:59 ` [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Marek Vasut
2012-10-06 15:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).