linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional
Date: Thu, 27 Sep 2012 02:29:54 +0200	[thread overview]
Message-ID: <201209270229.54462.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5Bi7gMH4RE047-uxc5bhz_UuQpLArpOSMae03U08tebxA@mail.gmail.com>

Dear Fabio Estevam,

> Hi Marek,
> 
> On Wed, Sep 26, 2012 at 9:00 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Fabio Estevam,
> > 
> > [...]
> > 
> >> +                                     interrupt-parent = <&gpio7>;
> >> +                                     interrupts = <11 0x8>; /*
> >> low-level
> > 
> > active IRQ at GPIO7_11 */
> > 
> > You mean active-low ? :-)
> 
> Actually I meant 'active low level-sensitive':
> 
> From Documentation/devicetree/bindings/gpio/fsl-imx-gpio.txt:
> 
>  The second cell bits[3:0] is used to specify trigger type and level flags:
>       1 = low-to-high edge triggered.
>       2 = high-to-low edge triggered.
>       4 = active high level-sensitive.
>       8 = active low level-sensitive

Thank you, I need to update my knowledge on the imx v7 :)

> > What was the conclusion on over-using regulator-always-on ?
> 
> I will be glad to get some suggestions about this.
> 
> With the original code the regulators were getting disabled, which
> caused some key power supplies to be removed and then system died.
> 
> Looking at the mx53qsb/DA9053 board schematics I cannot see any of
> these supplies that can be turned-off, and that's why I kept the
> 'always-on' flag.

I agree, let's see what Mark has to say. I believe your approach is valid.

> Regards,
> 
> Fabio Estevam

Best regards,
Marek Vasut

  reply	other threads:[~2012-09-27  0:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 23:27 [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Fabio Estevam
2012-09-26 23:27 ` [PATCH 2/3] ARM: dts: imx53-qsb: Make DA9053 regulator functional Fabio Estevam
2012-09-27  0:00   ` Marek Vasut
2012-09-27  0:12     ` Fabio Estevam
2012-09-27  0:29       ` Marek Vasut [this message]
2012-09-27 16:18         ` Mark Brown
2012-09-26 23:27 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add DA9052 regulator support Fabio Estevam
2012-09-27  0:01   ` Marek Vasut
2012-10-08  9:27   ` Sascha Hauer
2012-09-26 23:59 ` [PATCH 1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led Marek Vasut
2012-10-06 15:35 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209270229.54462.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).