From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] spi: atmel: add dmaengine and dt support
Date: Thu, 27 Sep 2012 09:39:31 +0200 [thread overview]
Message-ID: <20120927073931.GB31385@pengutronix.de> (raw)
In-Reply-To: <CACQ1gAi_e2nJNQv6TP1_F8b9ZHa9=F34gCB4nK7mH0Gvk0JhuQ@mail.gmail.com>
On Thu, Sep 27, 2012 at 09:13:13AM +0200, Richard Genoud wrote:
> 2012/9/26 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> > Hello,
> >
> > On Wed, Sep 26, 2012 at 02:50:57PM +0800, Wenyou Yang wrote:
> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> >
> > I don't remember ever having touched the spi-atmel driver, so I'm pretty
> > sure I never gave my S-o-b for anything in this patch. Please reread
> > Documentation/SubmittingPatches and double check you understood what
> > Signed-off-by means before resubmitting this patch with all wrong
> > S-o-b's removed.
>
> By the way, what is the correct way to send a patch based on other's work ?
> If I believe Documentation/SubmittingPatches, only the sender should
> add his S-o-b.
> But if you want to give credit to the original author(s), what's the best way ?
> IMHO, I would CC them, let them add their
> s-o-b/ack-b/nack-b/whatever-b if they want, and maybe add something
> like that in the file header :
> /*
> * based on the original work of ...
> */
> Or in the commit message itself
> Is that right ?
Yes. If you only did some trivia like rebasing to a new upstream version you
can additionally keep the original author as author.
Documentation/SubmittingPatches has some words about that, too. Grep for
"lucky at maintainer.example.org" to get the right paragraph.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-09-27 7:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 6:50 [PATCH 0/6] atmel SoC SPI controller with DT Wenyou Yang
2012-09-26 6:50 ` [PATCH 1/6] of_spi: add generic binding support to specify cs gpio Wenyou Yang
2012-09-26 6:50 ` [PATCH 2/6] spi: atmel: add dmaengine and dt support Wenyou Yang
2012-09-26 7:05 ` Uwe Kleine-König
2012-09-27 7:13 ` Richard Genoud
2012-09-27 7:39 ` Uwe Kleine-König [this message]
2012-09-27 8:08 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 8:15 ` Gregory CLEMENT
2012-09-26 6:50 ` [PATCH 3/6] ARM: at91: add clocks for spi DT entries Wenyou Yang
2012-09-26 8:32 ` Nicolas Ferre
2012-09-26 6:50 ` [PATCH 4/6] ARM: dts: add spi nodes for atmel SoCs Wenyou Yang
2012-09-26 6:51 ` [PATCH 5/6] ARM: dts: add spi nodes for atmel boards Wenyou Yang
2012-09-26 6:51 ` [PATCH 6/6] spi: atmel: add dt property for DMA configuration for sam9x5 and sam9n12 Wenyou Yang
2012-09-26 8:28 ` Nicolas Ferre
2012-09-26 14:15 ` [PATCH 0/6] atmel SoC SPI controller with DT Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927073931.GB31385@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).