From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] iommu/omap: Merge iommu2.h into iommu.h
Date: Thu, 27 Sep 2012 12:55:26 -0700 [thread overview]
Message-ID: <20120927195526.GP4840@atomide.com> (raw)
In-Reply-To: <20120927195313.GO4840@atomide.com>
* Tony Lindgren <tony@atomide.com> [120927 12:54]:
> Hi Ido,
>
> * Ido Yariv <ido@wizery.com> [120920 22:15]:
> > Since iommu is not currently supported on OMAP1, merge plat/iommu2.h into
> > iommu.h so only one file would have to move to platform_data/ as part of the
> > single zImage effort.
>
> Looks like you need patch 2.5/3 in this series too that
> makes some of the things defined in iommu.h local.
>
> We should only have platform data in include/linux/platform_data,
> so things that are private to drivers should be defined in the
> driver, and things that are private to arch/arm/mach-omap2 should
> defined locally there.
>
> Based on a quick grepping of files, looks like these should be
> defined in omap-iommu.c driver and not in the platform_data header:
>
> struct iotlb_lock
> struct iotlb_lock
> dev_to_omap_iommu
> various register defines
> omap_iommu_arch_version
> omap_iotlb_cr_to_e
> omap_iopgtable_store_entry
> omap_iommu_save_ctx
> omap_iommu_restore_ctx
> omap_foreach_iommu_device
> omap_iommu_dump_ctx
> omap_dump_tlb_entries
And looks like while at it, you can also move plat/iopgtable.h
and put it in some drivers/iommu/*.h file that's shared by
omap-iommu*.c and omap-iovmm.c drivers ;)
> Regards,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-27 19:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 5:14 [PATCH 1/3] [media] omap3isp: Fix compilation error in ispreg.h Ido Yariv
2012-09-21 5:14 ` [PATCH 2/3] iommu/omap: Merge iommu2.h into iommu.h Ido Yariv
2012-09-27 19:53 ` Tony Lindgren
2012-09-27 19:55 ` Tony Lindgren [this message]
2012-09-30 17:04 ` Ido Yariv
2012-10-01 22:46 ` [PATCH v2 1/5] [media] omap3isp: Fix compilation error in ispreg.h Ido Yariv
2012-10-01 22:46 ` [PATCH v2 2/5] iommu/omap: Merge iommu2.h into iommu.h Ido Yariv
2012-10-02 16:40 ` Tony Lindgren
2012-10-01 22:46 ` [PATCH v2 3/5] iommu/omap: Make some definitions local Ido Yariv
2012-10-01 22:46 ` [PATCH v2 4/5] arm: omap: Move iommu/iovmm headers to platform_data Ido Yariv
2012-10-01 22:46 ` [PATCH v2 5/5] arm: omap: Move iopgtable header to drivers/iommu/ Ido Yariv
2012-10-02 16:31 ` [PATCH v2 1/5] [media] omap3isp: Fix compilation error in ispreg.h Tony Lindgren
2012-10-07 13:17 ` Mauro Carvalho Chehab
2012-10-08 21:30 ` Tony Lindgren
2012-10-12 1:07 ` Laurent Pinchart
2012-09-21 5:14 ` [PATCH 3/3] arm: omap: Move iommu/iovmm headers to platform_data Ido Yariv
2012-09-27 19:22 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927195526.GP4840@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).