From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: optimize memset_io()/memcpy_fromio()/memcpy_toio()
Date: Fri, 28 Sep 2012 11:44:28 +0100 [thread overview]
Message-ID: <20120928104428.GE7916@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120928104216.GC18125@mudshark.cambridge.arm.com>
On Fri, Sep 28, 2012 at 11:42:16AM +0100, Will Deacon wrote:
> How are these regions mapped? If it's something like ioremap_wc, then this
> gives us normal non-cacheable memory on ARMv7, which wouldn't be subject to
> the restrictions that you have with device memory.
Yes, ioremap_wc() but we can't guarantee that for all causes of memset_io.
> > Either that or we allow DRM to be a security hole by omitting any kind
> > of buffer clearing, because using the existing memset_io() is just far
> > too expensive to clear 8MB a byte at a time.
>
> If DRM is using normal memory, it sounds like the *_io string functions need
> to be made to work with different memory types.
Take a look at the *_io string function declarations, and observe the use
of __iomem. That means they're only used with memory returned from the
ioremap*() suite of functions (or they're being used non-compliantly and
sparse should be spitting warnings.)
next prev parent reply other threads:[~2012-09-28 10:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 22:02 [PATCH] ARM: optimize memset_io()/memcpy_fromio()/memcpy_toio() Russell King
2012-09-28 4:17 ` Nicolas Pitre
2012-09-28 9:58 ` Will Deacon
2012-09-28 10:31 ` Russell King - ARM Linux
2012-09-28 10:42 ` Will Deacon
2012-09-28 10:44 ` Russell King - ARM Linux [this message]
2012-09-28 13:36 ` Arnd Bergmann
2012-09-28 14:13 ` Catalin Marinas
2012-09-28 14:29 ` Russell King - ARM Linux
2013-06-05 6:02 ` Dirk Behme
2013-06-11 18:16 ` Dirk Behme
2013-06-13 11:05 ` Russell King - ARM Linux
2013-06-13 12:47 ` Arnd Bergmann
2013-06-13 17:13 ` Russell King - ARM Linux
2013-06-23 6:46 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928104428.GE7916@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).