From: hverkuil@xs4all.nl (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dm644x: replace the obsolete preset API by the timings API.
Date: Fri, 28 Sep 2012 14:52:22 +0200 [thread overview]
Message-ID: <201209281452.22871.hverkuil@xs4all.nl> (raw)
In-Reply-To: <CA+V-a8tPQsc4-gS7jDCNy5PmsbTafoER9aXeL39_45Tk=0MjSw@mail.gmail.com>
Hi Prabhakar!
On Fri September 28 2012 14:44:59 Prabhakar Lad wrote:
> Hi Kevin,
>
> On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad <prabhakar.lad@ti.com> wrote:
> > From: Hans Verkuil <hans.verkuil@cisco.com>
> >
> > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > ---
> > arch/arm/mach-davinci/board-dm644x-evm.c | 15 ++--
> > arch/arm/mach-davinci/dm644x.c | 17 +---
> > drivers/media/video/davinci/vpbe.c | 110 ++++++++++++----------------
> > drivers/media/video/davinci/vpbe_display.c | 60 +++++++--------
> > drivers/media/video/davinci/vpbe_venc.c | 25 +++---
> > include/media/davinci/vpbe.h | 14 ++--
> > include/media/davinci/vpbe_types.h | 8 +--
> > include/media/davinci/vpbe_venc.h | 2 +-
> > 8 files changed, 111 insertions(+), 140 deletions(-)
> >
> Can you ACK this patch? Since this patch needs to go from Mauro's tree
> due to changes in media drivers folder structure.
>
> Regards,
> --Prabhakar Lad
>
...
> > -static int vpbe_s_dv_preset(struct vpbe_device *vpbe_dev,
> > - struct v4l2_dv_preset *dv_preset)
> > +static int vpbe_s_dv_timings(struct vpbe_device *vpbe_dev,
> > + struct v4l2_dv_timings *dv_timings)
> > {
> > struct vpbe_config *cfg = vpbe_dev->cfg;
> > int out_index = vpbe_dev->current_out_index;
> > + struct vpbe_output *output = &cfg->outputs[out_index];
> > int sd_index = vpbe_dev->current_sd_index;
> > - int ret;
> > + int ret, i;
> >
> >
> > if (!(cfg->outputs[out_index].output.capabilities &
> > - V4L2_OUT_CAP_PRESETS))
> > + V4L2_OUT_CAP_CUSTOM_TIMINGS))
Can you make a follow-up patch that renames V4L2_IN/OUT_CAP_CUSTOM_TIMINGS to
V4L2_IN/OUT_CAP_DV_TIMINGS? The old name for this define is deprecated, so it
would be nice to fix this in this driver as well.
The code that adds the new define names went in just two days ago, so as far
as I am concerned there is no need to modify the patch again. A follow-up
patch is sufficient.
Regards,
Hans
next prev parent reply other threads:[~2012-09-28 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 12:30 [PATCH 0/2] Replace the obsolete preset API by timings API Prabhakar Lad
2012-08-08 12:30 ` [PATCH 1/2] dm644x: replace the obsolete preset API by the " Prabhakar Lad
2012-09-28 12:44 ` Prabhakar Lad
2012-09-28 12:52 ` Hans Verkuil [this message]
2012-09-28 12:55 ` Prabhakar Lad
2012-10-01 11:29 ` Sekhar Nori
2012-08-08 12:30 ` [PATCH 2/2] ths7303: enable THS7303 for HD modes Prabhakar Lad
2012-09-18 5:10 ` [PATCH 0/2] Replace the obsolete preset API by timings API Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209281452.22871.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox