From: david@gibson.dropbear.id.au (David Gibson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] Fix segfault in DTC
Date: Mon, 1 Oct 2012 16:46:10 +1000 [thread overview]
Message-ID: <20121001064610.GA5323@truffula.fritz.box> (raw)
In-Reply-To: <50692B7A.8000405@wwwdotorg.org>
On Sun, Sep 30, 2012 at 11:34:50PM -0600, Stephen Warren wrote:
> On 09/29/2012 05:53 PM, David Gibson wrote:
> > On Fri, Sep 28, 2012 at 01:05:33PM -0600, Stephen Warren wrote:
> >> On 09/28/2012 12:53 PM, Jon Loeliger wrote:
> >>>>>
> >>>>> Yeah, seems like the kernel DTC is quite old.
> >>>>
> >>>> FYI, I'm working on a patch to the kernel to bring in the latest dtc.
> >>>
> >>> Awesome. Thank you.
> >>>
> >>>> I've run a regression test vs. the old dtc in the kernel ...
> >>>
> >>> Which is the icky step. Again, thank you.
> >>>
> >>>> ... and found that
> >>>> some of the PowerPC .dts files don't compile with the new dtc (but did
> >>>> with the old), all due to non-existent labels/paths being referenced.
> >>>> I'll try and track down whether this is a regression in dtc, or simply
> >>>> buggy .dts files that weren't noticed before.
> >>>
> >>> I think you should just smack the PowerPC guys. :-)
> >>
> >> For the record in this thread, it was a regression I introduced into dtc
> >> - the patch I just sent was for this.
> >
> > I would be nice to add a testcase for this regression into dtc.
>
> The issue here was caused by uninitialized memory, so it would, I think,
> be basically impossible to create a test-case that would be guaranteed
> to fail because of this; it'd depend on the internal details of the
> malloc library and how/when it re-used previously free()d memory blocks.
It doesn't have to be guaranteed to fail to be useful. Plus, we
already have the infrastructure to run the tests under valgrind, which
would catch it.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-10-01 6:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 22:48 [PATCH 0/1] Fix segfault in DTC Markus Mayer
2012-09-24 22:48 ` [PATCH 1/1] " Markus Mayer
2012-09-25 11:07 ` [PATCH 0/1] " Will Deacon
2012-09-25 15:44 ` Stephen Warren
2012-09-25 16:42 ` Markus Mayer
2012-09-25 17:58 ` Markus Mayer
2012-09-25 17:58 ` [PATCH 1/1] " Markus Mayer
2012-09-25 23:30 ` David Gibson
2012-09-25 23:51 ` Markus Mayer
2012-09-26 0:35 ` David Gibson
2012-09-26 16:38 ` Markus Mayer
2012-09-28 17:09 ` Stephen Warren
2012-09-28 18:53 ` Jon Loeliger
2012-09-28 19:05 ` Stephen Warren
2012-09-28 20:32 ` Jon Loeliger
2012-09-29 23:53 ` David Gibson
2012-10-01 5:34 ` Stephen Warren
2012-10-01 6:46 ` David Gibson [this message]
2012-10-01 16:41 ` Stephen Warren
2012-10-02 0:08 ` David Gibson
2012-10-03 21:33 ` Stephen Warren
2012-10-04 4:49 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001064610.GA5323@truffula.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).