Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree
Date: Tue, 2 Oct 2012 22:07:53 +0200	[thread overview]
Message-ID: <20121002200753.GA12565@lunn.ch> (raw)

> Date: Tue,  2 Oct 2012 18:01:00 +0200
> From: Fabio Porcedda <fabio.porcedda@gmail.com>
> To: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog at vger.kernel.org,
>         linux-arm-kernel at lists.infradead.org, Nicolas Ferre
>         <nicolas.ferre@atmel.com>, Jean-Christophe PLAGNIOL-VILLARD
>         <plagnioj@jcrosoft.com>, Andrew Victor <linux@maxim.org.za>
> Cc: devicetree-discuss at lists.ozlabs.org
> Subject: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree
>         support
> Message-ID:
>         <1349193662-23482-2-git-send-email-fabio.porcedda@gmail.com>
> 
> Tested on an at91sam9260 board (evk-pro3)
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> +++ b/drivers/watchdog/at91sam9_wdt.c
> @@ -32,6 +32,7 @@
>  #include <linux/timer.h>
>  #include <linux/bitops.h>
>  #include <linux/uaccess.h>
> +#include <linux/of.h>
> 
>  #include "at91sam9_wdt.h"
> 
> > @@ -302,11 +303,21 @@ static int __exit at91wdt_remove(struct platform_device *pdev)
>         return res;
>  }
> 
> +#if defined(CONFIG_OF)
> +static const struct of_device_id at91_wdt_dt_ids[] = {
> +       { .compatible = "atmel,at91sam9260-wdt" },
> +       { /* sentinel */ }
> +};

Hi Fabio

You are missing __devinitdata.

    Andrew

             reply	other threads:[~2012-10-02 20:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 20:07 Andrew Lunn [this message]
2012-10-03 14:10 ` [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121002200753.GA12565@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox