From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: include linux/sched.h in syscall.h
Date: Fri, 5 Oct 2012 00:09:57 +0100 [thread overview]
Message-ID: <20121004230957.GC4625@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121002155255.GJ11278@mudshark.cambridge.arm.com>
On Tue, Oct 02, 2012 at 04:52:55PM +0100, Will Deacon wrote:
> On Tue, Oct 02, 2012 at 04:43:44PM +0100, Wade Farnsworth wrote:
> > > On Mon, Oct 01, 2012 at 09:10:08PM +0100, Wade Farnsworth wrote:
> > >> task_thread_info() is defined in linux/sched.h. Explicitly include this
> > >> file in arch/arm/include/asm/syscall.h. This fixes an lttng-modules compile error.
> > >
> > > Can you be more specific about the error? From your description, it sounds
> > > like it should be fixed in lttng rather than here.
> > >
> > My apologies for the lack of clarity.
> >
> > My syscall tracing patch introduces a compile bug in lttng-modules when
> > the latter calls syscall_get_nr(), similar to the following:
> >
> > <path-to-linux>/arch/arm/include/asm/syscall.h:21:2: error: implicit
> > declaration of function 'task_thread_info'
> > [-Werror=implicit-function-declaration]
> >
> > The issue is that we are using task_thread_info() in the
> > syscall_get_nr() function in asm/syscall.h, but not explicitly including
> > sched.h from this file, so we can expect this bug might surface any time
> > that syscall_get_nr() is called.
> >
> > Hopefully that clarifies things somewhat.
>
> Yep, thanks. Your patch sounds like the right thing to do, but please
> include the compiler error in your commit log.
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>From what I can tell, the original commit went in during the 3.4..3.5
timeframe, so doesn't this patch need to be applied to v3.5-stable
as well as 3.6-stable and for 3.7 ?
next prev parent reply other threads:[~2012-10-04 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 20:10 [PATCH] arm: include linux/sched.h in syscall.h Wade Farnsworth
2012-10-02 12:21 ` Will Deacon
2012-10-02 15:43 ` Wade Farnsworth
2012-10-02 15:52 ` Will Deacon
2012-10-04 23:09 ` Russell King - ARM Linux [this message]
2012-10-05 9:16 ` Will Deacon
2012-10-05 9:39 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004230957.GC4625@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).