* [PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS
@ 2012-10-07 8:00 Axel Lin
2012-10-07 8:23 ` Russell King - ARM Linux
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-10-07 8:00 UTC (permalink / raw)
To: linux-arm-kernel
This fixes below build error:
LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow
make: *** [vmlinux] Error 1
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Bryan,
I think this issue is introduced by commit dafbead
"ARM: mach-omap1: retire custom LED code".
Regards,
Axel
arch/arm/plat-omap/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index ca83a76..3281377 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -42,7 +42,7 @@ config OMAP_DEBUG_DEVICES
For debug cards on TI reference boards.
config OMAP_DEBUG_LEDS
- def_bool y if NEW_LEDS
+ default y if LEDS_CLASS
depends on OMAP_DEBUG_DEVICES
config POWER_AVS_OMAP
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS
2012-10-07 8:00 [PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS Axel Lin
@ 2012-10-07 8:23 ` Russell King - ARM Linux
0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2012-10-07 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Oct 07, 2012 at 04:00:37PM +0800, Axel Lin wrote:
> config OMAP_DEBUG_LEDS
> - def_bool y if NEW_LEDS
> + default y if LEDS_CLASS
> depends on OMAP_DEBUG_DEVICES
This change is wrong. You're making this config entry untyped.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-07 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-07 8:00 [PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS Axel Lin
2012-10-07 8:23 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).