From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Problem with 64-bit registers on i.MX53
Date: Mon, 8 Oct 2012 18:10:11 +0100 [thread overview]
Message-ID: <20121008171011.GA4625@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121008170124.GZ4625@n2100.arm.linux.org.uk>
On Mon, Oct 08, 2012 at 06:01:24PM +0100, Russell King - ARM Linux wrote:
> On Mon, Oct 08, 2012 at 06:08:41PM +0200, Michael Olbrich wrote:
> >
> > Hi,
> >
> > I have a problem that looks like that 64-bit registers (I think) are not
> > saved/restored correctly on a context switch. I've reduced it to the
> > following test case:
> >
> > - Latest Linux mainline kernel (v3.6-8559-ge9eca4d)
> > v3.5 is also affected
> > - imx_v6_v7_defconfig
> > - arch/arm/boot/dts/imx53-evk.dts
> >
> > The following test program is compiled with "-mcpu=cortex-a8 -mfpu=neon
> > -O2".
> > ------------------------>8--------------------------------
> > #include <inttypes.h>
> > #include <assert.h>
> >
> > volatile int x = 2;
> > volatile int64_t y = 2;
> >
> > int main() {
> > volatile int a = 0;
> > volatile int64_t b = 0;
> > while (1) {
> > a = (a + x) % (1 << 30);
> > b = (b + y) % (1 << 30);
> > assert(a == b);
> > }
> > }
> > ------------------------>8--------------------------------
> > The ".. (b + y) .." should result in "vadd.i64 d19, d18, d16" or
> > something like that.
>
> Hmm.
>
> Can you send me the output of 'grep ^Features /proc/cpuinfo' please?
You may also like to try the patch below... it will probably fix your
problem.
diff --git a/arch/arm/include/asm/vfpmacros.h b/arch/arm/include/asm/vfpmacros.h
index a7aadbd..6a6f1e4 100644
--- a/arch/arm/include/asm/vfpmacros.h
+++ b/arch/arm/include/asm/vfpmacros.h
@@ -28,7 +28,7 @@
ldr \tmp, =elf_hwcap @ may not have MVFR regs
ldr \tmp, [\tmp, #0]
tst \tmp, #HWCAP_VFPv3D16
- ldceq p11, cr0, [\base],#32*4 @ FLDMIAD \base!, {d16-d31}
+ ldceql p11, cr0, [\base],#32*4 @ FLDMIAD \base!, {d16-d31}
addne \base, \base, #32*4 @ step over unused register space
#else
VFPFMRX \tmp, MVFR0 @ Media and VFP Feature Register 0
@@ -52,7 +52,7 @@
ldr \tmp, =elf_hwcap @ may not have MVFR regs
ldr \tmp, [\tmp, #0]
tst \tmp, #HWCAP_VFPv3D16
- stceq p11, cr0, [\base],#32*4 @ FSTMIAD \base!, {d16-d31}
+ stceql p11, cr0, [\base],#32*4 @ FSTMIAD \base!, {d16-d31}
addne \base, \base, #32*4 @ step over unused register space
#else
VFPFMRX \tmp, MVFR0 @ Media and VFP Feature Register 0
next prev parent reply other threads:[~2012-10-08 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 16:08 Problem with 64-bit registers on i.MX53 Michael Olbrich
2012-10-08 17:01 ` Russell King - ARM Linux
2012-10-08 17:10 ` Russell King - ARM Linux [this message]
2012-10-08 17:50 ` Dave Martin
2012-10-08 18:03 ` Russell King - ARM Linux
2012-10-08 18:04 ` Dave Martin
2012-10-09 9:02 ` Michael Olbrich
2012-10-09 8:52 ` Michael Olbrich
2012-10-09 9:02 ` Uwe Kleine-König
2012-10-09 14:05 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008171011.GA4625@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).