* [PATCH] ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()
@ 2012-09-21 6:30 Wei Yongjun
2012-10-08 21:34 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-21 6:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function omap_device_alloc() returns ERR_PTR()
not NULL pointer. The NULL test in the return value check should
be replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/mach-omap2/hsmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
index a9675d8..95179fe 100644
--- a/arch/arm/mach-omap2/hsmmc.c
+++ b/arch/arm/mach-omap2/hsmmc.c
@@ -522,7 +522,7 @@ static void __init omap_hsmmc_init_one(struct omap2_hsmmc_info *hsmmcinfo,
dev_set_name(&pdev->dev, "%s.%d", pdev->name, pdev->id);
od = omap_device_alloc(pdev, ohs, 1, NULL, 0);
- if (!od) {
+ if (IS_ERR(od)) {
pr_err("Could not allocate od for %s\n", name);
goto put_pdev;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()
2012-09-21 6:30 [PATCH] ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one() Wei Yongjun
@ 2012-10-08 21:34 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-10-08 21:34 UTC (permalink / raw)
To: linux-arm-kernel
* Wei Yongjun <weiyj.lk@gmail.com> [120920 23:31]:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function omap_device_alloc() returns ERR_PTR()
> not NULL pointer. The NULL test in the return value check should
> be replaced with IS_ERR().
Thanks applying into omap fixes.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-08 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-21 6:30 [PATCH] ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one() Wei Yongjun
2012-10-08 21:34 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).