* [PATCH] ARM: OMAP2+: gpmc: annotate exit sections properly
@ 2012-10-04 8:31 Afzal Mohammed
2012-10-08 21:51 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Afzal Mohammed @ 2012-10-04 8:31 UTC (permalink / raw)
To: linux-arm-kernel
compiler complained,
`gpmc_remove' referenced in section `.data' of arch/arm/mach-omap2/built-in.o: defined in discarded section `.exit.text' of arch/arm/mach-omap2/built-in.o
Annotate gpmc_remove function and dependents with __devexit.
Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
Hi,
Section mismatch occured due to my change,
"ARM: OMAP2+: gpmc: minimal driver support".
As this change is not yet in vanilla, SHA1 has not been
mentioned in commit log. Original change that introduced the
above mentioned warning has as of now swimmed only till
linux-omap and linux-next.
This has been generated against linux-next (next-20121003)
Regards
Afzal
arch/arm/mach-omap2/gpmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 8ab1e1b..5ac5cf3 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -838,7 +838,7 @@ static int gpmc_setup_irq(void)
return request_irq(gpmc_irq, gpmc_handle_irq, 0, "gpmc", NULL);
}
-static __exit int gpmc_free_irq(void)
+static __devexit int gpmc_free_irq(void)
{
int i;
@@ -944,7 +944,7 @@ static __devinit int gpmc_probe(struct platform_device *pdev)
return 0;
}
-static __exit int gpmc_remove(struct platform_device *pdev)
+static __devexit int gpmc_remove(struct platform_device *pdev)
{
gpmc_free_irq();
gpmc_mem_exit();
--
1.7.12
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: OMAP2+: gpmc: annotate exit sections properly
2012-10-04 8:31 [PATCH] ARM: OMAP2+: gpmc: annotate exit sections properly Afzal Mohammed
@ 2012-10-08 21:51 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-10-08 21:51 UTC (permalink / raw)
To: linux-arm-kernel
* Afzal Mohammed <afzal@ti.com> [121004 01:33]:
> compiler complained,
> `gpmc_remove' referenced in section `.data' of arch/arm/mach-omap2/built-in.o: defined in discarded section `.exit.text' of arch/arm/mach-omap2/built-in.o
>
> Annotate gpmc_remove function and dependents with __devexit.
Thanks applying into omap fixes.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-08 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 8:31 [PATCH] ARM: OMAP2+: gpmc: annotate exit sections properly Afzal Mohammed
2012-10-08 21:51 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).