From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: pm: add suspend_mem and suspend_standby support
Date: Tue, 9 Oct 2012 17:17:04 +0200 [thread overview]
Message-ID: <20121009151704.GP12801@game.jcrosoft.org> (raw)
In-Reply-To: <20121009145854.GB14079@kroah.com>
On 07:58 Tue 09 Oct , Greg Kroah-Hartman wrote:
> On Tue, Oct 09, 2012 at 01:46:33PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 22:02 Sun 07 Oct , Rafael J. Wysocki wrote:
> > > On Sunday 07 of October 2012 15:12:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > On 00:18 Sun 07 Oct , Rafael J. Wysocki wrote:
> > > > > On Saturday 06 of October 2012 18:14:29 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > > > Hi,
> > > > > >
> > > > > > The following changes since commit 5f3d2f2e1a63679cf1c4a4210f2f1cc2f335bef6:
> > > > > >
> > > > > > Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc (2012-10-06 03:16:12 +0900)
> > > > > >
> > > > > > are available in the git repository at:
> > > > > >
> > > > > >
> > > > > > git://git.jcrosoft.org/linux-2.6.git tags/pm_suspend_standby_mem
> > > > > >
> > > > > > for you to fetch changes up to b73c8f97aa8e720bd3b921159687d00626c99d63:
> > > > > >
> > > > > > arm: at91: drop at91_suspend_entering_slow_clock (2012-10-06 18:06:25 +0800)
> > > > > >
> > > > > > ----------------------------------------------------------------
> > > > > > pm: add suspend_mem and suspend_standby support
> > > > > >
> > > > > > Today when we go to suspend we can not knwon at drivers level if we go in
> > > > > > STANDBY or MEM. Fix this by introducing two new callback suspend_mem and
> > > > > > suspend_standby.
> > > > >
> > > > > No way. Device drivers shouldn't be concerned about that.
> > > > I do need it on at91 as we swith to slow_clock in MEM suspend and some ip
> > > > need special handling when switching to slow_clock
> > >
> > > Well, my answer to that is: please fix your platform code instead of
> > > hacking the PM core to work around its problems.
> > how can I fix drivers pm issue when I no way to known at driver level the
> > real suspend, the PM core is supposed to proivde the right information to the
> > drivers so the driver can put it's in the right pm mode. If the pm core can not
> > provide such inforation the PM core is broken as we will have to do dirty
> > hack.
>
> Why do you need to know the difference in your driver? We used to
> provide this information a long time ago, but it turned out to not be
> needed at all and just caused problems.
because on at91 I need to handle the mem standby at drviers level.
We do it today already by a hack in different drivers at91_udc (usb device),
atmel_serail and at91_ohci. Those 3 IP have specifci handling when switching
to mem pm. On at91 when switch to mem we shutdown everything and run form a slow
clock - this is done at soc level - but those IP have issue and need specific
care before doing so. Ohterwise when the SoC will wakeup but those IP will not
in this patch series I send the update of those 3 drivers too
and kill the hack
>
> > Any generic framework is supposed to evolve for real user need here I've one
> > so I udpate the core to mach a need
>
> I'll push back and ask again why your driver cares about this? It
> shouldn't.
I'm doing it right now in the kernel but in a dirty way and want to fix it.
And honestly If I could not do it I will
Best Regards,
J.
next prev parent reply other threads:[~2012-10-09 15:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 16:14 pm: add suspend_mem and suspend_standby support Jean-Christophe PLAGNIOL-VILLARD
2012-10-06 22:18 ` Rafael J. Wysocki
2012-10-07 4:01 ` Greg Kroah-Hartman
2012-10-07 13:09 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 20:06 ` Rafael J. Wysocki
2012-10-07 13:12 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 20:02 ` Rafael J. Wysocki
2012-10-09 11:46 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 14:58 ` Greg Kroah-Hartman
2012-10-09 15:17 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-09 15:44 ` Alan Stern
2012-10-09 15:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 22:18 ` Rafael J. Wysocki
2012-10-09 22:12 ` Rafael J. Wysocki
2012-10-10 7:17 ` Vaibhav Hiremath
2012-10-10 9:20 ` Daniel Mack
2012-10-10 9:29 ` Hiremath, Vaibhav
2012-10-10 9:33 ` Daniel Mack
2012-10-31 10:27 ` Daniel Mack
2012-10-31 10:44 ` AM33XX suspend-resume support (Was RE: pm: add suspend_mem and suspend_standby support) Bedia, Vaibhav
2012-10-10 9:43 ` pm: add suspend_mem and suspend_standby support Jean-Christophe PLAGNIOL-VILLARD
2012-10-14 7:12 ` Rafael J. Wysocki
2012-10-10 23:05 ` Rafael J. Wysocki
2012-10-13 6:46 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 22:09 ` Rafael J. Wysocki
2012-10-07 7:27 ` [PATCH 1/6] " Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 7:27 ` [PATCH 2/6] platform: " Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 7:27 ` [PATCH 3/6] tty: atmel_serial: switch pm ops Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 7:27 ` [PATCH 4/6] usb: ohci-at91: " Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 7:27 ` [PATCH 5/6] usb: at91_ude: " Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 7:27 ` [PATCH 6/6] arm: at91: drop at91_suspend_entering_slow_clock Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 22:52 ` [PATCH 1/6] pm: add suspend_mem and suspend_standby support Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009151704.GP12801@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).