* [PATCH] ARM: dts: imx28: add the `clock-names` for gpmi-nand
@ 2012-10-10 2:44 Huang Shijie
2012-10-10 4:54 ` Fabio Estevam
0 siblings, 1 reply; 10+ messages in thread
From: Huang Shijie @ 2012-10-10 2:44 UTC (permalink / raw)
To: linux-arm-kernel
The current DT node misses the `clocks-names` item for gpmi-nand.
So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
arch/arm/boot/dts/imx28.dtsi | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index e16d631..55c57ea 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -85,6 +85,7 @@
interrupts = <88>, <41>;
interrupt-names = "gpmi-dma", "bch";
clocks = <&clks 50>;
+ clock-names = "gpmi_io";
fsl,gpmi-dma-channel = <4>;
status = "disabled";
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: imx28: add the `clock-names` for gpmi-nand
2012-10-10 2:44 [PATCH] ARM: dts: imx28: add the `clock-names` for gpmi-nand Huang Shijie
@ 2012-10-10 4:54 ` Fabio Estevam
2012-10-10 5:01 ` Huang Shijie
2012-10-10 6:15 ` [PATCH] ARM: dts: mxs: " Huang Shijie
0 siblings, 2 replies; 10+ messages in thread
From: Fabio Estevam @ 2012-10-10 4:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Huang,
On Tue, Oct 9, 2012 at 11:44 PM, Huang Shijie <b32955@freescale.com> wrote:
> The current DT node misses the `clocks-names` item for gpmi-nand.
> So the gpmi-nand driver could not find the proper clock.
>
> This patch fixes this issue.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Thanks for the fix.
Could you please also fix mx23 in the same patch?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: imx28: add the `clock-names` for gpmi-nand
2012-10-10 4:54 ` Fabio Estevam
@ 2012-10-10 5:01 ` Huang Shijie
2012-10-10 6:15 ` [PATCH] ARM: dts: mxs: " Huang Shijie
1 sibling, 0 replies; 10+ messages in thread
From: Huang Shijie @ 2012-10-10 5:01 UTC (permalink / raw)
To: linux-arm-kernel
? 2012?10?10? 12:54, Fabio Estevam ??:
> Hi Huang,
>
> On Tue, Oct 9, 2012 at 11:44 PM, Huang Shijie<b32955@freescale.com> wrote:
>> The current DT node misses the `clocks-names` item for gpmi-nand.
>> So the gpmi-nand driver could not find the proper clock.
>>
>> This patch fixes this issue.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
> Thanks for the fix.
>
> Could you please also fix mx23 in the same patch?
I am just fixing it now. :)
Huang Shijie
> Regards,
>
> Fabio Estevam
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: mxs: add the `clock-names` for gpmi-nand
2012-10-10 4:54 ` Fabio Estevam
2012-10-10 5:01 ` Huang Shijie
@ 2012-10-10 6:15 ` Huang Shijie
2012-10-10 10:37 ` Marek Vasut
1 sibling, 1 reply; 10+ messages in thread
From: Huang Shijie @ 2012-10-10 6:15 UTC (permalink / raw)
To: linux-arm-kernel
The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
arch/arm/boot/dts/imx23.dtsi | 1 +
arch/arm/boot/dts/imx28.dtsi | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
index 9ca4ca7..6d31aa3 100644
--- a/arch/arm/boot/dts/imx23.dtsi
+++ b/arch/arm/boot/dts/imx23.dtsi
@@ -69,6 +69,7 @@
interrupts = <13>, <56>;
interrupt-names = "gpmi-dma", "bch";
clocks = <&clks 34>;
+ clock-names = "gpmi_io";
fsl,gpmi-dma-channel = <4>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index e16d631..55c57ea 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -85,6 +85,7 @@
interrupts = <88>, <41>;
interrupt-names = "gpmi-dma", "bch";
clocks = <&clks 50>;
+ clock-names = "gpmi_io";
fsl,gpmi-dma-channel = <4>;
status = "disabled";
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: mxs: add the `clock-names` for gpmi-nand
2012-10-10 6:15 ` [PATCH] ARM: dts: mxs: " Huang Shijie
@ 2012-10-10 10:37 ` Marek Vasut
2012-10-10 10:27 ` [PATCH] ARM: dts: mxs: add the "clock-names" " Huang Shijie
0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2012-10-10 10:37 UTC (permalink / raw)
To: linux-arm-kernel
Dear Huang Shijie,
> The current DT nodes for mx23/mx28 miss the `clocks-names` item for
> gpmi-nand. So the gpmi-nand driver could not find the proper clock.
>
> This patch fixes this issue.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
[...]
One more rant: Can you discard that weird backtick in the patch subject? Maybe
use '' ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: mxs: add the "clock-names" for gpmi-nand
2012-10-10 10:37 ` Marek Vasut
@ 2012-10-10 10:27 ` Huang Shijie
2012-10-10 11:34 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Huang Shijie @ 2012-10-10 10:27 UTC (permalink / raw)
To: linux-arm-kernel
The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
arch/arm/boot/dts/imx23.dtsi | 1 +
arch/arm/boot/dts/imx28.dtsi | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
index 9ca4ca7..6d31aa3 100644
--- a/arch/arm/boot/dts/imx23.dtsi
+++ b/arch/arm/boot/dts/imx23.dtsi
@@ -69,6 +69,7 @@
interrupts = <13>, <56>;
interrupt-names = "gpmi-dma", "bch";
clocks = <&clks 34>;
+ clock-names = "gpmi_io";
fsl,gpmi-dma-channel = <4>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index e16d631..55c57ea 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -85,6 +85,7 @@
interrupts = <88>, <41>;
interrupt-names = "gpmi-dma", "bch";
clocks = <&clks 50>;
+ clock-names = "gpmi_io";
fsl,gpmi-dma-channel = <4>;
status = "disabled";
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] ARM: dts: mxs: add the "clock-names" for gpmi-nand
2012-10-10 10:27 ` [PATCH] ARM: dts: mxs: add the "clock-names" " Huang Shijie
@ 2012-10-10 11:34 ` Marek Vasut
2012-10-11 7:49 ` Shawn Guo
2012-10-25 7:16 ` Shawn Guo
2 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2012-10-10 11:34 UTC (permalink / raw)
To: linux-arm-kernel
Dear Huang Shijie,
> The current DT nodes for mx23/mx28 miss the `clocks-names` item for
> gpmi-nand. So the gpmi-nand driver could not find the proper clock.
>
> This patch fixes this issue.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
[...]
Reviewed-by: Marek Vasut <marex@denx.de>
I will test later today.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: mxs: add the "clock-names" for gpmi-nand
2012-10-10 10:27 ` [PATCH] ARM: dts: mxs: add the "clock-names" " Huang Shijie
2012-10-10 11:34 ` Marek Vasut
@ 2012-10-11 7:49 ` Shawn Guo
2012-10-25 7:16 ` Shawn Guo
2 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2012-10-11 7:49 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 10, 2012 at 06:27:09PM +0800, Huang Shijie wrote:
> The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
> So the gpmi-nand driver could not find the proper clock.
>
> This patch fixes this issue.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Applied, thanks.
Shawn
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: mxs: add the "clock-names" for gpmi-nand
2012-10-10 10:27 ` [PATCH] ARM: dts: mxs: add the "clock-names" " Huang Shijie
2012-10-10 11:34 ` Marek Vasut
2012-10-11 7:49 ` Shawn Guo
@ 2012-10-25 7:16 ` Shawn Guo
2012-10-25 13:23 ` Arnd Bergmann
2 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2012-10-25 7:16 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd, Olof,
Can you please apply this fix for -rc? Otherwise, please let me know
if you prefer to get a pull request from me.
Shawn
On Wed, Oct 10, 2012 at 06:27:09PM +0800, Huang Shijie wrote:
> The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
> So the gpmi-nand driver could not find the proper clock.
>
> This patch fixes this issue.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> arch/arm/boot/dts/imx23.dtsi | 1 +
> arch/arm/boot/dts/imx28.dtsi | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
> index 9ca4ca7..6d31aa3 100644
> --- a/arch/arm/boot/dts/imx23.dtsi
> +++ b/arch/arm/boot/dts/imx23.dtsi
> @@ -69,6 +69,7 @@
> interrupts = <13>, <56>;
> interrupt-names = "gpmi-dma", "bch";
> clocks = <&clks 34>;
> + clock-names = "gpmi_io";
> fsl,gpmi-dma-channel = <4>;
> status = "disabled";
> };
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e16d631..55c57ea 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -85,6 +85,7 @@
> interrupts = <88>, <41>;
> interrupt-names = "gpmi-dma", "bch";
> clocks = <&clks 50>;
> + clock-names = "gpmi_io";
> fsl,gpmi-dma-channel = <4>;
> status = "disabled";
> };
> --
> 1.7.0.4
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-10-25 13:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 2:44 [PATCH] ARM: dts: imx28: add the `clock-names` for gpmi-nand Huang Shijie
2012-10-10 4:54 ` Fabio Estevam
2012-10-10 5:01 ` Huang Shijie
2012-10-10 6:15 ` [PATCH] ARM: dts: mxs: " Huang Shijie
2012-10-10 10:37 ` Marek Vasut
2012-10-10 10:27 ` [PATCH] ARM: dts: mxs: add the "clock-names" " Huang Shijie
2012-10-10 11:34 ` Marek Vasut
2012-10-11 7:49 ` Shawn Guo
2012-10-25 7:16 ` Shawn Guo
2012-10-25 13:23 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).