From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit
Date: Thu, 11 Oct 2012 18:38:51 +0200 [thread overview]
Message-ID: <20121011183851.277e79da@skate> (raw)
In-Reply-To: <5076E9F1.60200@gmail.com>
Rob,
On Thu, 11 Oct 2012 10:46:57 -0500, Rob Herring wrote:
> > +Required properties:
> > +- compatible: should be "marvell,neta".
>
> This should be more specific such as "marvell,armada-xp-neta".
>
> Or use 370 instead of xp. It should be which ever chip came first.
>
> > +- reg: address and length of the register set for the device.
> > +- interrupts: interrupt for the device
> > +- phy-mode: String, operation mode of the PHY interface. Supported
> > + values are "sgmii" and "rmii".
> > +- phy-addr: Integer, address of the PHY.
> > +- device_type: should be "network".
>
> Drop this. device_type is not used for FDT.
>
> > +- clock-frequency: frequency of the peripheral clock of the SoC.
> > +
> > +Example:
> > +
> > +eth at d0070000 {
>
> Should be ethernet at ...
Thanks for your comments. Will fix in v3.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-11 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 15:27 [PATCH v2] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Thomas Petazzoni
2012-10-11 15:27 ` [PATCH v2 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Thomas Petazzoni
2012-10-11 15:46 ` Rob Herring
2012-10-11 16:38 ` Thomas Petazzoni [this message]
2012-10-12 14:16 ` Thomas Petazzoni
2012-10-11 18:13 ` Baruch Siach
2012-10-11 21:26 ` Francois Romieu
2012-10-12 14:31 ` Jason Cooper
2012-10-12 14:59 ` Thomas Petazzoni
2012-10-12 16:03 ` Jason Cooper
2012-10-11 15:28 ` [PATCH v2 2/4] net: mvneta: update MAINTAINERS file for the mvneta maintainers Thomas Petazzoni
2012-10-11 15:28 ` [PATCH v2 3/4] arm: mvebu: add Ethernet controllers using mvneta driver for Armada 370/XP Thomas Petazzoni
2012-10-11 15:28 ` [PATCH v2 4/4] arm: mvebu: enable Ethernet controllers on Armada 370/XP eval boards Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011183851.277e79da@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).