From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: change the id to let the i2c device work
Date: Fri, 12 Oct 2012 13:40:58 +0900 [thread overview]
Message-ID: <20121012044042.GI11726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1350009258-10044-1-git-send-email-voice.shen@atmel.com>
On Fri, Oct 12, 2012 at 10:34:18AM +0800, Bo Shen wrote:
> As the old method will use platform device id, change the id to
> let the i2c device work
What are "the old method" and new method? You're not explaining why
this is needed...
> static struct platform_device at91sam9260_twi_device = {
> .name = "i2c-gpio",
> - .id = -1,
> + .id = 0,
> .dev.platform_data = &pdata,
This looks like a regression, if there's only one of a given type of
device in the system it should have no numeric ID in the display name so
having -1 is appropriate.
next prev parent reply other threads:[~2012-10-12 4:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 2:34 [PATCH] i2c: change the id to let the i2c device work Bo Shen
2012-10-12 4:40 ` Mark Brown [this message]
2012-10-12 4:57 ` Bo Shen
2012-10-12 5:14 ` Mark Brown
2012-10-12 5:45 ` Bo Shen
2012-10-12 5:53 ` Mark Brown
2012-10-12 6:42 ` Bo Shen
2012-10-12 7:14 ` Jean Delvare
2012-10-12 7:55 ` Bo Shen
2012-10-12 8:05 ` Jean Delvare
2012-10-12 8:21 ` Mark Brown
2012-10-12 9:02 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012044042.GI11726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).